Issue 13239049: Update charm token per ux.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13239049: Update charm token per ux.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rharding

Modified:
10 years, 8 months ago

Reviewers:
j.c.sackett, mp+184322

Visibility:
Public.

Description

Update charm token per ux. - Update to show series - Update to show owner if not reviewed, else show 'recommended' - Remove description - change commits/downloads to "Deployed XX times" - Updated to appear cleanly on the fullscreen reviewed charms view, but the data is not in the api currently so it shows up incomplete. To QA: Load the gui and look through the sidebar, make sure to look down in the new charms to view non-recommended charms, etc. Do searches and make sure the tokens show correctly and you can distinguish between different charms in the results. Load a single charm in fullscreen mode and note how the related charms don't have the series/owner info because that info is not in the charm /related api. e.g. /fullscreen/precise/mysql-10 https://code.launchpad.net/~rharding/juju-gui/charm-token-update/+merge/184322 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update charm token per ux. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -80 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/charm.js	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	app/templates/charm-token.handlebars	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	app/widgets/charm-token.js	View	6 chunks	+51 lines, -55 lines	0 comments	Download
M	test/test_charm_token.js	View	1 chunk	+38 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

j.c.sackett

LGTM, QA ok. As a note though, on the small tokens, the "precise | Recommended" ...

10 years, 8 months ago (2013-09-06 15:10:27 UTC) #2

rharding

10 years, 8 months ago (2013-09-06 15:32:26 UTC) #3

*** Submitted:

Update charm token per ux.

- Update to show series
- Update to show owner if not reviewed, else show 'recommended'
- Remove description
- change commits/downloads to "Deployed XX times"
- Updated to appear cleanly on the fullscreen reviewed charms view, but the
data is not in the api currently so it shows up incomplete. 


To QA:

Load the gui and look through the sidebar, make sure to look down in the new
charms to view non-recommended charms, etc.

Do searches and make sure the tokens show correctly and you can distinguish
between different charms in the results.

Load a single charm in fullscreen mode and note how the related charms don't
have the series/owner info because that info is not in the charm /related api.

e.g. 

/fullscreen/precise/mysql-10

R=j.c.sackett
CC=
https://codereview.appspot.com/13239049

Expand All Messages | Collapse All Messages