Issue 13237053: Adds relation error support to simulator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13237053: Adds relation error support to simulator

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by jeff.pihach

Modified:
10 years, 8 months ago

Reviewers:
mp+183922, frankban

Visibility:
Public.

Description

Adds relation error support to simulator https://code.launchpad.net/~hatch/juju-gui/relation-error-simulator/+merge/183922 (do not edit description out of merge proposal)

Patch Set 2 : Adds relation error support to simulator #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -5 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/simulator.js	View		1 chunk	+20 lines, -4 lines	0 comments	Download
M	app/templates/unitOverview.handlebars	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	app/views/utils.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/views/viewlet-manager.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

frankban

LGTM, thank you https://codereview.appspot.com/13237053/diff/1/app/views/utils.js File app/views/utils.js (right): https://codereview.appspot.com/13237053/diff/1/app/views/utils.js#newcode1175 app/views/utils.js:1175: if (state === 'error') { You ...

10 years, 8 months ago (2013-09-04 16:42:41 UTC) #2

jeff.pihach

10 years, 8 months ago (2013-09-04 16:49:46 UTC) #3

*** Submitted:

Adds relation error support to simulator

R=frankban
CC=
https://codereview.appspot.com/13237053

Expand All Messages | Collapse All Messages