Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1022)

Issue 13237052: Update sandbox to send proper data on ServiceGet

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rharding
Modified:
10 years, 8 months ago
Reviewers:
benjamin.saller, mp+183875
Visibility:
Public.

Description

Update sandbox to send proper data on ServiceGet - The real environment passes the config and constraints on service get. - Add a test through get_service to verify we get the processed data. https://code.launchpad.net/~rharding/juju-gui/go-config-deploy/+merge/183875 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update sandbox to send proper data on ServiceGet #

Patch Set 3 : Update sandbox to send proper data on ServiceGet #

Patch Set 4 : Update sandbox to send proper data on ServiceGet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -17 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/store/env/sandbox.js View 1 chunk +34 lines, -4 lines 0 comments Download
M app/views/databinding.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M app/views/viewlets/service-config.js View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M test/test_sandbox_go.js View 2 chunks +36 lines, -12 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 8 months ago (2013-09-04 14:43:40 UTC) #1
rharding
Please take a look.
10 years, 8 months ago (2013-09-04 14:48:01 UTC) #2
benjamin.saller
LGTM, thanks
10 years, 8 months ago (2013-09-04 15:13:48 UTC) #3
rharding
10 years, 8 months ago (2013-09-04 15:37:33 UTC) #4
*** Submitted:

Update sandbox to send proper data on ServiceGet

- The real environment passes the config and constraints on service get.
- Add a test through get_service to verify we get the processed data.

R=benjamin.saller
CC=
https://codereview.appspot.com/13237052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b