Issue 13237045: additional metadata for list guid, Object type and parent web title

Issue 13237045: additional metadata for list guid, Object type and parent web title (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Tanmay Vartak

Modified:
10 years, 8 months ago

Reviewers:
ejona

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

additional metadata for list guid, Object type and parent web title

Patch Set 2 : with code review comments #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -3 lines)			Patch
M	src/com/google/enterprise/adaptor/sharepoint/RareModificationCache.java	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java	View	1	10 chunks	+35 lines, -3 lines	2 comments	Download
M	test/com/google/enterprise/adaptor/sharepoint/SharePointAdaptorTest.java	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Tanmay Vartak

https://codereview.appspot.com/13237045/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/13237045/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode1628 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:1628: ObjectType.LIST_ITEM_ATTACHMENTS.value()); ObjectType.LIST_ITEM_ATTACHMENTS.value() is ListItemAttachments. Should we just use "Attachment" ...

10 years, 8 months ago (2013-08-27 00:00:32 UTC) #2

ejona

https://codereview.appspot.com/13237045/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/13237045/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode935 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:935: response.addMetadata(METADATA_OBJECT_TYPE, ObjectType.SITE.value()); Could these be ordered consistently? I'd assume ...

10 years, 8 months ago (2013-08-27 00:49:15 UTC) #3

ejona

10 years, 8 months ago (2013-08-27 18:40:34 UTC) #5

LGTM

https://codereview.appspot.com/13237045/diff/7001/src/com/google/enterprise/a...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
(right):

https://codereview.appspot.com/13237045/diff/7001/src/com/google/enterprise/a...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:1473: }
Don't add whitespace to this unmodified line.

https://codereview.appspot.com/13237045/diff/7001/src/com/google/enterprise/a...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:1507:
writer.finish();
Don't add whitespace to this unmodified line.

Expand All Messages | Collapse All Messages