Issue 13236045: code review 13236045: cmd/go: add -race flag to 'go list'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13236045: code review 13236045: cmd/go: add -race flag to 'go list' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by r

Modified:
12 years, 3 months ago

Reviewers:
bradfitz

CC:
golang-dev, dave_cheney.net, bradfitz

Visibility:
Public.

Description

cmd/go: add -race flag to 'go list' Causes the package dependencies to include those for race detection. Fixes issue 5653.

Patch Set 1 #

Patch Set 2 : diff -r 162abca105d5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 162abca105d5 https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/cmd/go/list.go	View		3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-08-29 00:46:16 UTC) #1

dave_cheney.net

On 2013/08/29 00:46:16, r wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

12 years, 3 months ago (2013-08-29 00:48:00 UTC) #2

Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2013-08-29 00:50:26 UTC) #3

12 years, 3 months ago (2013-08-29 01:17:02 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=96b98e28d49e ***

cmd/go: add -race flag to 'go list'

Causes the package dependencies to include those for race detection.
Fixes issue 5653.

R=golang-dev, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/13236045

Expand All Messages | Collapse All Messages