Issue 13235047: Remove leftover check

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13235047: Remove leftover check

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by matthew.scott

Modified:
10 years, 8 months ago

Reviewers:
rharding, mp+183639

Visibility:
Public.

Description

Remove leftover check A leftover if statement was preventing relation lines from being removed in the go sandbox (uncovered by previous branch). Tested in py/go sandbox, and improv. https://code.launchpad.net/~makyo/juju-gui/go-remove-relations/+merge/183639 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove leftover check #

Patch Set 3 : Remove leftover check #

Patch Set 4 : Remove leftover check #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/relation.js	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/test_bundle_module.js	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

matthew.scott

10 years, 8 months ago (2013-09-03 13:02:19 UTC) #5

*** Submitted:

Remove leftover check

A leftover if statement was preventing relation lines from being removed in the
go sandbox (uncovered by previous branch).  Tested in py/go sandbox, and improv.

R=rharding
CC=
https://codereview.appspot.com/13235047

Expand All Messages | Collapse All Messages