Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1040)

Issue 13234052: code review 13234052: cmd/go: fix error for 'go install x.go' when GOBIN is n... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

cmd/go: fix error for 'go install x.go' when GOBIN is not set Fixes issue 6191. Fixes issue 5426.

Patch Set 1 #

Patch Set 2 : diff -r 2d673b7f9c9e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2d673b7f9c9e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 1e6d3c8bb93f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/cmd/go/build.go View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/cmd/go/pkg.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/go/test.bash View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2013-09-10 17:43:48 UTC) #1
bradfitz
LGTM
10 years, 6 months ago (2013-09-10 17:55:35 UTC) #2
rsc
10 years, 6 months ago (2013-09-10 18:41:10 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=8ef79645ac2e ***

cmd/go: fix error for 'go install x.go' when GOBIN is not set

Fixes issue 6191.
Fixes issue 5426.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13234052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b