Issue 13234050: code review 13234050: runtime: remove OABI check from ARM startup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13234050: code review 13234050: runtime: remove OABI check from ARM startup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
minux1

CC:
golang-dev, minux1

Visibility:
Public.

Description

runtime: remove OABI check from ARM startup The code in question is trying to print a nice error message when a Go EABI binary runs on an OABI machine. Unfortunately, the only way to do that is to use ARM Thumb instructions, which we otherwise don't use. There exist ARM EABI machines that do not support Thumb. We could run on them if not for this OABI check, so disable it. Fixes issue 5685.

Patch Set 1 #

Patch Set 2 : diff -r 873dcabd042f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 873dcabd042f https://code.google.com/p/go/ #

Patch Set 4 : diff -r c45fa194202f https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -20 lines)			Patch
	M	src/pkg/runtime/rt0_linux_arm.s	View	1	1 chunk	+25 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-09 17:16:20 UTC) #1

minux1

LGTM. this is unfortunate, but it seems we have no other choices.

11 years, 6 months ago (2013-09-09 17:21:03 UTC) #2

rsc

11 years, 6 months ago (2013-09-09 19:06:09 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=07e461525486 ***

runtime: remove OABI check from ARM startup

The code in question is trying to print a nice error message
when a Go EABI binary runs on an OABI machine.
Unfortunately, the only way to do that is to use
ARM Thumb instructions, which we otherwise don't use.

There exist ARM EABI machines that do not support Thumb.
We could run on them if not for this OABI check, so disable it.

Fixes issue 5685.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/13234050

Expand All Messages | Collapse All Messages