Issue 13233043: code review 13233043: misc/emacs: allow users to customize path of 'go' tool.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13233043: code review 13233043: misc/emacs: allow users to customize path of 'go' tool. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by adonovan

Modified:
11 years, 8 months ago

Reviewers:
Dominik Honnef

CC:
Dominik Honnef, golang-dev

Visibility:
Public.

Description

misc/emacs: allow users to customize path of 'go' tool. Some users have multiple Go development trees and invoke the 'go' tool via a wrapper that sets GOROOT and GOPATH based on the current directory. Such users should customize go-command to point to the wrapper script.

Patch Set 1 #

Patch Set 2 : code review 13233043: misc/emacs: allow users to customize path of 'go' tool. #

Patch Set 3 : diff -r 14a416a72f8c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 14a416a72f8c https://code.google.com/p/go/ #

Patch Set 5 : diff -r 44f80a8685c7 https://code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	misc/emacs/go-mode.el	View	1 2 3 4	3 chunks	+14 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello dominik.honnef@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-08-26 20:01:21 UTC) #1

adonovan

11 years, 8 months ago (2013-08-27 13:48:00 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=320fdeb9fec1 ***

misc/emacs: allow users to customize path of 'go' tool.

Some users have multiple Go development trees and invoke the
'go' tool via a wrapper that sets GOROOT and GOPATH based on
the current directory.  Such users should customize go-command
to point to the wrapper script.

R=dominik.honnef
CC=golang-dev
https://codereview.appspot.com/13233043

Expand All Messages | Collapse All Messages