Issue 132300043: code review 132300043: spec: move Method expr/value section near selectors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 132300043: code review 132300043: spec: move Method expr/value section near selectors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by gri

Modified:
10 years, 8 months ago

Reviewers:
rsc, iant

CC:
r, rsc, iant, ken2, golang-codereviews

Visibility:
Public.

Description

spec: move Method expr/value section near selectors Preparation for fixing issue 5769 (method selectors do not auto-dereference): The actual fix may require some cleanups in all these sections, and syntactically, method expressions and method values are selector expressions. Moving them next to each other so that it's easy to see the actual changes (next CL). No content changes besides the section moves.

Patch Set 1 #

Patch Set 2 : diff -r 8b5fc7c59d0597d0626080fea96fce4bbeff6860 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 8b5fc7c59d0597d0626080fea96fce4bbeff6860 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c0bf0888678455984619f00a4daef478098de026 https://code.google.com/p/go/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -227 lines)			Patch
	M	doc/go_spec.html	View	1	3 chunks	+228 lines, -227 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org, rsc@golang.org, iant@golang.org, ken@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...

10 years, 8 months ago (2014-08-28 00:27:34 UTC) #1

gri

10 years, 8 months ago (2014-08-28 15:53:29 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=9298940afb88 ***

spec: move Method expr/value section near selectors

Preparation for fixing issue 5769 (method selectors
do not auto-dereference): The actual fix may require
some cleanups in all these sections, and syntactically,
method expressions and method values are selector
expressions. Moving them next to each other so that
it's easy to see the actual changes (next CL).

No content changes besides the section moves.

LGTM=iant, rsc
R=r, rsc, iant, ken
CC=golang-codereviews
https://codereview.appspot.com/132300043

Expand All Messages | Collapse All Messages