Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(364)

Issue 13229043: Removes not supported IE10 warning

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jeff.pihach
Modified:
10 years, 8 months ago
Reviewers:
mp+182169, gary.poster, rharding
Visibility:
Public.

Description

Removes not supported IE10 warning Tests have been updated and the selenium tests use the results of the js isbrowserSupported method to know if it should interact with the warning or not. https://code.launchpad.net/~hatch/juju-gui/remove-ie-warning/+merge/182169 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removes not supported IE10 warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 2 chunks +3 lines, -3 lines 0 comments Download
M test/test_startup.js.bottom View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
10 years, 8 months ago (2013-08-26 17:26:00 UTC) #1
rharding
LGTM and qa's ok in IE10
10 years, 8 months ago (2013-08-26 17:31:07 UTC) #2
gary.poster
LGTM thank you!
10 years, 8 months ago (2013-08-26 17:31:22 UTC) #3
jeff.pihach
Thanks for the reviews!
10 years, 8 months ago (2013-08-26 17:32:57 UTC) #4
jeff.pihach
10 years, 8 months ago (2013-08-26 17:39:56 UTC) #5
*** Submitted:

Removes not supported IE10 warning

Tests have been updated and the selenium tests use the
results of the js isbrowserSupported method to know if
it should interact with the warning or not.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/13229043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b