code review 13225043: cmd/5l,cmd/6l,cmd/8l: fix dragonflydynld path

cmd/5l,cmd/6l,cmd/8l: fix dragonflydynld path

[jsing, 2013-08-26 15:04:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-08-26 15:14:17]

What does XXX force?
 On Aug 26, 2013 10:04 AM, <jsing@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/5l,cmd/6l,cmd/8l: fix dragonflydynld path
>
> Please review this at
https://codereview.appspot.**com/13225043/<https://codereview.appspot.com/132...
>
> Affected files:
>   M src/cmd/5l/asm.c
>   M src/cmd/6l/asm.c
>   M src/cmd/8l/asm.c
>
>
> Index: src/cmd/5l/asm.c
> ==============================**==============================**=======
> --- a/src/cmd/5l/asm.c
> +++ b/src/cmd/5l/asm.c
> @@ -41,7 +41,7 @@
>  char freebsddynld[] = "/usr/libexec/ld-elf.so.1";
>  char openbsddynld[] = "XXX";
>  char netbsddynld[] = "/libexec/ld.elf_so";
> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
> +char dragonflydynld[] = "XXX";
>
>  int32
>  entryvalue(void)
> Index: src/cmd/6l/asm.c
> ==============================**==============================**=======
> --- a/src/cmd/6l/asm.c
> +++ b/src/cmd/6l/asm.c
> @@ -43,7 +43,7 @@
>  char freebsddynld[] = "/libexec/ld-elf.so.1";
>  char openbsddynld[] = "/usr/libexec/ld.so";
>  char netbsddynld[] = "/libexec/ld.elf_so";
> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
> +char dragonflydynld[] = "/usr/libexec/ld-elf.so.2";
>
>  char   zeroes[32];
>
> Index: src/cmd/8l/asm.c
> ==============================**==============================**=======
> --- a/src/cmd/8l/asm.c
> +++ b/src/cmd/8l/asm.c
> @@ -41,7 +41,7 @@
>  char freebsddynld[] = "/usr/libexec/ld-elf.so.1";
>  char openbsddynld[] = "/usr/libexec/ld.so";
>  char netbsddynld[] = "/usr/libexec/ld.elf_so";
> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
> +char dragonflydynld[] = "/usr/libexec/ld-elf.so.2";
>
>  int32
>  entryvalue(void)
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[dave_cheney.net, 2013-08-26 21:41:55]

Nothing, it's just a placeholder as the value must be present, but has no valid
value for those platforms. 



On 27/08/2013, at 1:14, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> What does XXX force?
> On Aug 26, 2013 10:04 AM, <jsing@google.com> wrote:
>> Reviewers: golang-dev1,
>> 
>> Message:
>> Hello golang-dev@googlegroups.com,
>> 
>> I'd like you to review this change to
>> https://go.googlecode.com/hg/
>> 
>> 
>> Description:
>> cmd/5l,cmd/6l,cmd/8l: fix dragonflydynld path
>> 
>> Please review this at https://codereview.appspot.com/13225043/
>> 
>> Affected files:
>>   M src/cmd/5l/asm.c
>>   M src/cmd/6l/asm.c
>>   M src/cmd/8l/asm.c
>> 
>> 
>> Index: src/cmd/5l/asm.c
>> ===================================================================
>> --- a/src/cmd/5l/asm.c
>> +++ b/src/cmd/5l/asm.c
>> @@ -41,7 +41,7 @@
>>  char freebsddynld[] = "/usr/libexec/ld-elf.so.1";
>>  char openbsddynld[] = "XXX";
>>  char netbsddynld[] = "/libexec/ld.elf_so";
>> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
>> +char dragonflydynld[] = "XXX";
>> 
>>  int32
>>  entryvalue(void)
>> Index: src/cmd/6l/asm.c
>> ===================================================================
>> --- a/src/cmd/6l/asm.c
>> +++ b/src/cmd/6l/asm.c
>> @@ -43,7 +43,7 @@
>>  char freebsddynld[] = "/libexec/ld-elf.so.1";
>>  char openbsddynld[] = "/usr/libexec/ld.so";
>>  char netbsddynld[] = "/libexec/ld.elf_so";
>> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
>> +char dragonflydynld[] = "/usr/libexec/ld-elf.so.2";
>> 
>>  char   zeroes[32];
>> 
>> Index: src/cmd/8l/asm.c
>> ===================================================================
>> --- a/src/cmd/8l/asm.c
>> +++ b/src/cmd/8l/asm.c
>> @@ -41,7 +41,7 @@
>>  char freebsddynld[] = "/usr/libexec/ld-elf.so.1";
>>  char openbsddynld[] = "/usr/libexec/ld.so";
>>  char netbsddynld[] = "/usr/libexec/ld.elf_so";
>> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
>> +char dragonflydynld[] = "/usr/libexec/ld-elf.so.2";
>> 
>>  int32
>>  entryvalue(void)
>> 
>> 
>> -- 
>> 
>> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
> 
> -- 
>  
> --- 
> You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[bradfitz, 2013-08-27 15:28:23]

LGTM



On Mon, Aug 26, 2013 at 8:04 AM, <jsing@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/5l,cmd/6l,cmd/8l: fix dragonflydynld path
>
> Please review this at
https://codereview.appspot.**com/13225043/<https://codereview.appspot.com/132...
>
> Affected files:
>   M src/cmd/5l/asm.c
>   M src/cmd/6l/asm.c
>   M src/cmd/8l/asm.c
>
>
> Index: src/cmd/5l/asm.c
> ==============================**==============================**=======
> --- a/src/cmd/5l/asm.c
> +++ b/src/cmd/5l/asm.c
> @@ -41,7 +41,7 @@
>  char freebsddynld[] = "/usr/libexec/ld-elf.so.1";
>  char openbsddynld[] = "XXX";
>  char netbsddynld[] = "/libexec/ld.elf_so";
> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
> +char dragonflydynld[] = "XXX";
>
>  int32
>  entryvalue(void)
> Index: src/cmd/6l/asm.c
> ==============================**==============================**=======
> --- a/src/cmd/6l/asm.c
> +++ b/src/cmd/6l/asm.c
> @@ -43,7 +43,7 @@
>  char freebsddynld[] = "/libexec/ld-elf.so.1";
>  char openbsddynld[] = "/usr/libexec/ld.so";
>  char netbsddynld[] = "/libexec/ld.elf_so";
> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
> +char dragonflydynld[] = "/usr/libexec/ld-elf.so.2";
>
>  char   zeroes[32];
>
> Index: src/cmd/8l/asm.c
> ==============================**==============================**=======
> --- a/src/cmd/8l/asm.c
> +++ b/src/cmd/8l/asm.c
> @@ -41,7 +41,7 @@
>  char freebsddynld[] = "/usr/libexec/ld-elf.so.1";
>  char openbsddynld[] = "/usr/libexec/ld.so";
>  char netbsddynld[] = "/usr/libexec/ld.elf_so";
> -char dragonflydynld[] = "/libexec/ld-elf.so.2";
> +char dragonflydynld[] = "/usr/libexec/ld-elf.so.2";
>
>  int32
>  entryvalue(void)
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[jsing, 2013-08-31 12:02:32]

*** Submitted as https://code.google.com/p/go/source/detail?r=f795546f1c55 ***

cmd/5l,cmd/6l,cmd/8l: fix dragonflydynld path

R=golang-dev, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/13225043