Fixes #1125352 adding constraints ui to deploy.

Fixes #1125352 adding constraints ui to deploy.

- Adds the template and UI to the ghost viewlet.
- Currently adds it to the top of the display until we get
accordion/collapsing UX into place
- Adds constraints into the call to deploy to send it to the back end.
- Removes the old Go formatting code as it's not required
- Renames the viewlet-manager template to service-config-wrapper to match
ghost-config-wrapper and to be more truthful to what it is.
- Small gardening.

https://code.launchpad.net/~rharding/juju-gui/ghost-constraints-1125352/+merge/181553

(do not edit description out of merge proposal)

[rharding, 2013-08-26 15:01:15]

Please take a look.

[matthew.scott, 2013-08-26 15:22:51]

LGTM, IEQA okay.

[jeff.pihach, 2013-08-26 15:27:38]

LGTM with the changes mentioned below.

Thanks for doing this!

https://codereview.appspot.com/13224043/diff/5001/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/13224043/diff/5001/app/store/env/go.js#newcode122
app/store/env/go.js:122: genericConstraints: ['cpu-power', 'cpu-cores', 'mem',
'arch'],
These should probably be moved into the utils object with the other generic
constraints and renamed to goGenericConstraints

https://codereview.appspot.com/13224043/diff/5001/app/templates/ghost-config-...
File app/templates/ghost-config-viewlet.handlebars (right):

https://codereview.appspot.com/13224043/diff/5001/app/templates/ghost-config-...
app/templates/ghost-config-viewlet.handlebars:17: {{> service-constraints}}
I think this should be service-constraints-viewlet.partial

https://codereview.appspot.com/13224043/diff/5001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/13224043/diff/5001/app/views/environment.js#ne...
app/views/environment.js:219: template:
Y.juju.views.Templates['service-config-wrapper']
So you just renamed the file?

https://codereview.appspot.com/13224043/diff/5001/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/13224043/diff/5001/app/views/ghost-inspector.j...
app/views/ghost-inspector.js:305: requires: [
Did you forget to add modules here?

https://codereview.appspot.com/13224043/diff/5001/app/views/viewlets/service-...
File app/views/viewlets/service-ghost.js (right):

https://codereview.appspot.com/13224043/diff/5001/app/views/viewlets/service-...
app/views/viewlets/service-ghost.js:57: model.get('options'));
templateOptions.options

no need to run another get()

[rharding, 2013-08-26 15:41:17]

Feedback on the review below.

https://codereview.appspot.com/13224043/diff/5001/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/13224043/diff/5001/app/store/env/go.js#newcode122
app/store/env/go.js:122: genericConstraints: ['cpu-power', 'cpu-cores', 'mem',
'arch'],
On 2013/08/26 15:27:38, jeff.pihach wrote:
> These should probably be moved into the utils object with the other generic
> constraints and renamed to goGenericConstraints

The genericConstraints are always in the env they go with. This also exists in
the python version. This is part of my undoing work I mis-understood last week
in getting the deploy code to build 'go' formatted constraints objects.

https://codereview.appspot.com/13224043/diff/5001/app/templates/ghost-config-...
File app/templates/ghost-config-viewlet.handlebars (right):

https://codereview.appspot.com/13224043/diff/5001/app/templates/ghost-config-...
app/templates/ghost-config-viewlet.handlebars:17: {{> service-constraints}}
On 2013/08/26 15:27:38, jeff.pihach wrote:
> I think this should be service-constraints-viewlet.partial

Thanks for the catch. Too many templates named the same thing.

https://codereview.appspot.com/13224043/diff/5001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/13224043/diff/5001/app/views/environment.js#ne...
app/views/environment.js:219: template:
Y.juju.views.Templates['service-config-wrapper']
On 2013/08/26 15:27:38, jeff.pihach wrote:
> So you just renamed the file?

Yes, the name viewlet-manager was a mis-nomer since the viewlet-manager is also
used for ghost-inspectors but won't use this template.

https://codereview.appspot.com/13224043/diff/5001/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/13224043/diff/5001/app/views/ghost-inspector.j...
app/views/ghost-inspector.js:305: requires: [
On 2013/08/26 15:27:38, jeff.pihach wrote:
> Did you forget to add modules here?

Well, I noticed that this module doesn't require anything, but uses a bunch of
items. When I went to add modules in, I ended up getting errors from YUI. I
emptied it back out. I wanted to note it's not complete, but needs research on
why I was getting errors when I did include modules there.

https://codereview.appspot.com/13224043/diff/5001/app/views/viewlets/service-...
File app/views/viewlets/service-ghost.js (right):

https://codereview.appspot.com/13224043/diff/5001/app/views/viewlets/service-...
app/views/viewlets/service-ghost.js:57: model.get('options'));
On 2013/08/26 15:27:38, jeff.pihach wrote:
> templateOptions.options
> 
> no need to run another get()

rgr

[rharding, 2013-08-26 17:08:46]

*** Submitted:

Fixes #1125352 adding constraints ui to deploy.

- Adds the template and UI to the ghost viewlet.
- Currently adds it to the top of the display until we get
accordion/collapsing UX into place
- Adds constraints into the call to deploy to send it to the back end.
- Removes the old Go formatting code as it's not required
- Renames the viewlet-manager template to service-config-wrapper to match
ghost-config-wrapper and to be more truthful to what it is.
- Small gardening.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/13224043