Cleaning WebKitDriver code (HLWK).

[Eran, 2010-05-26 15:41:23]

I've outlined several things which do not conform to the Google and general Java
style guide. I am sure I have not caught all instances, please review the code
and fix all of the instances.

http://codereview.appspot.com/1321041/diff/1/3
File hlwk/WebKit/hl/JavaBindings.cpp (right):

http://codereview.appspot.com/1321041/diff/1/3#newcode121
hlwk/WebKit/hl/JavaBindings.cpp:121: FrameLoaderClientHl *client =
(FrameLoaderClientHl*)frame->loader()->client();
Keep the braces - it makes the code easier to read by *not* forcing the reader
to look up the operator precedence rules and in this case, also explains what's
being casted.

http://codereview.appspot.com/1321041/diff/1/3#newcode194
hlwk/WebKit/hl/JavaBindings.cpp:194: if (element == NULL ||
!element->isStyledElement())
Leave the curly braces, even if there's one line of code. This is error prone
(and I've seen bugs arising from this more than once). This is an official
recommendation of Java which Google embraced:
http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#449

http://codereview.appspot.com/1321041/diff/1/3#newcode200
hlwk/WebKit/hl/JavaBindings.cpp:200: if (style)
Same here.

http://codereview.appspot.com/1321041/diff/1/3#newcode244
hlwk/WebKit/hl/JavaBindings.cpp:244: if (node->nodeName() == "TITLE")
Same here.

http://codereview.appspot.com/1321041/diff/1/3#newcode254
hlwk/WebKit/hl/JavaBindings.cpp:254: else if (getProperty((Element*)node,
String("visibility")) == "visible")
Same here.

http://codereview.appspot.com/1321041/diff/1/3#newcode257
hlwk/WebKit/hl/JavaBindings.cpp:257: visible = false;
And here.

http://codereview.appspot.com/1321041/diff/1/3#newcode259
hlwk/WebKit/hl/JavaBindings.cpp:259: if (!start && !isNone)
and here.

http://codereview.appspot.com/1321041/diff/1/3#newcode360
hlwk/WebKit/hl/JavaBindings.cpp:360: else
Same here, for both if and else statements.

http://codereview.appspot.com/1321041/diff/1/3#newcode405
hlwk/WebKit/hl/JavaBindings.cpp:405: if (*cycle)
Here as well.

http://codereview.appspot.com/1321041/diff/1/3#newcode456
hlwk/WebKit/hl/JavaBindings.cpp:456: env->CallBooleanMethod(result, adding,
arrayObj);
And here.

http://codereview.appspot.com/1321041/diff/1/3#newcode462
hlwk/WebKit/hl/JavaBindings.cpp:462: if (!objClass || !cid)
Here as well.

http://codereview.appspot.com/1321041/diff/1/3#newcode526
hlwk/WebKit/hl/JavaBindings.cpp:526: if (!exec->hadException())
Here.

http://codereview.appspot.com/1321041/diff/1/3#newcode617
hlwk/WebKit/hl/JavaBindings.cpp:617: if ((drv != NULL) && (drv->GetFrame() !=
NULL))
Here for both statements.

http://codereview.appspot.com/1321041/diff/1/3#newcode674
hlwk/WebKit/hl/JavaBindings.cpp:674: if(doc == NULL)
Here.

http://codereview.appspot.com/1321041/diff/1/3#newcode754
hlwk/WebKit/hl/JavaBindings.cpp:754: if (output.right(1) == " ")
And here.

http://codereview.appspot.com/1321041/diff/1/3#newcode771
hlwk/WebKit/hl/JavaBindings.cpp:771: if (output.right(1) == " ")
Here.