Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6158)

Issue 13207043: code review 13207043: go.crypto/ssh/terminal: handle ^W, ^K and ^H (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by agl1
Modified:
10 years, 8 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

go.crypto/ssh/terminal: handle ^W, ^K and ^H

Patch Set 1 #

Patch Set 2 : diff -r bcb404348307 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r bcb404348307 https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r e402c6ee12fd https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -40 lines) Patch
M ssh/terminal/terminal.go View 1 5 chunks +93 lines, -39 lines 0 comments Download
M ssh/terminal/terminal_test.go View 1 1 chunk +37 lines, -1 line 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
10 years, 8 months ago (2013-08-24 15:38:57 UTC) #1
bradfitz
LGTM On Sat, Aug 24, 2013 at 10:38 AM, <agl@golang.org> wrote: > Reviewers: golang-dev1, > ...
10 years, 8 months ago (2013-08-24 15:42:04 UTC) #2
agl1
10 years, 8 months ago (2013-08-28 11:36:04 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=69c3cecb8b4f&repo=crypto ***

go.crypto/ssh/terminal: handle ^W, ^K and ^H

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13207043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b