code review 13203043: os/user: Current() support on Plan 9

os/user: Current() support on Plan 9

Current() for Plan 9 is implemented with /dev/user for Uid/Gid/Username/Name, and $home environment variable for HomeDir.

Implementing Lookup()/LookupId() is not done, which would require parsing /adm/users. It is unclear of how much benefit this would be.

[mischief, 2013-08-24 01:42:07]

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org, r@golang.org),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-24 02:03:31]

LGTM



On Fri, Aug 23, 2013 at 8:42 PM, <mischief@offblast.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org,
> r@golang.org),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
>       os/user: Current() support on Plan 9
>
> Current() for Plan 9 is implemented with /dev/user for
> Uid/Gid/Username/Name, and $home environment variable for HomeDir.
>
> Implementing Lookup()/LookupId() is not done, which would require
> parsing /adm/users. It is unclear of how much benefit this would be.
>
> Please review this at
https://codereview.appspot.**com/13203043/<https://codereview.appspot.com/132...
>
> Affected files:
>   A src/pkg/os/user/lookup_plan9.**go
>   M src/pkg/os/user/lookup_stubs.**go
>   M src/pkg/os/user/user.go
>   M src/pkg/os/user/user_test.go
>
>
> Index: src/pkg/os/user/lookup_plan9.**go
> ==============================**==============================**=======
> new file mode 100644
> --- /dev/null
> +++ b/src/pkg/os/user/lookup_**plan9.go
> @@ -0,0 +1,46 @@
> +// Copyright 2013 The Go Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package user
> +
> +import (
> +       "fmt"
> +       "io/ioutil"
> +       "os"
> +       "syscall"
> +)
> +
> +// Partial os/user support on Plan 9.
> +// Supports Current(), but not Lookup()/LookupId().
> +// The latter two would require parsing /adm/users.
> +const (
> +       userFile = "/dev/user"
> +)
> +
> +func current() (*User, error) {
> +       ubytes, err := ioutil.ReadFile(userFile)
> +       if err != nil {
> +               return nil, fmt.Errorf("user: %s", err)
> +       }
> +
> +       uname := string(ubytes)
> +
> +       u := &User{
> +               Uid:      uname,
> +               Gid:      uname,
> +               Username: uname,
> +               Name:     uname,
> +               HomeDir:  os.Getenv("home"),
> +       }
> +
> +       return u, nil
> +}
> +
> +func lookup(username string) (*User, error) {
> +       return nil, syscall.EPLAN9
> +}
> +
> +func lookupId(uid string) (*User, error) {
> +       return nil, syscall.EPLAN9
> +}
> Index: src/pkg/os/user/lookup_stubs.**go
> ==============================**==============================**=======
> --- a/src/pkg/os/user/lookup_**stubs.go
> +++ b/src/pkg/os/user/lookup_**stubs.go
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -// +build !cgo,!windows
> +// +build !cgo,!windows,!plan9
>
>  package user
>
> Index: src/pkg/os/user/user.go
> ==============================**==============================**=======
> --- a/src/pkg/os/user/user.go
> +++ b/src/pkg/os/user/user.go
> @@ -16,6 +16,8 @@
>  // On posix systems Uid and Gid contain a decimal number
>  // representing uid and gid. On windows Uid and Gid
>  // contain security identifier (SID) in a string format.
> +// On Plan 9, Uid, Gid, Username, and Name will be the
> +// contents of /dev/user.
>  type User struct {
>         Uid      string // user id
>         Gid      string // primary group id
> Index: src/pkg/os/user/user_test.go
> ==============================**==============================**=======
> --- a/src/pkg/os/user/user_test.go
> +++ b/src/pkg/os/user/user_test.go
> @@ -14,7 +14,7 @@
>                 t.Skip("user: not implemented; skipping tests")
>         }
>         switch runtime.GOOS {
> -       case "linux", "freebsd", "darwin", "windows":
> +       case "linux", "freebsd", "darwin", "windows", "plan9":
>                 // test supported
>         default:
>                 t.Skipf("user: Lookup not implemented on %q; skipping
> test", runtime.GOOS)
> @@ -61,6 +61,10 @@
>  func TestLookup(t *testing.T) {
>         check(t)
>
> +       if runtime.GOOS == "plan9" {
> +               t.Skipf("Lookup not implemented on %q", runtime.GOOS)
> +       }
> +
>         want, err := Current()
>         if err != nil {
>                 t.Fatalf("Current: %v", err)
> @@ -75,6 +79,10 @@
>  func TestLookupId(t *testing.T) {
>         check(t)
>
> +       if runtime.GOOS == "plan9" {
> +               t.Skipf("LookupId not implemented on %q", runtime.GOOS)
> +       }
> +
>         want, err := Current()
>         if err != nil {
>                 t.Fatalf("Current: %v", err)
>
>
>

[bradfitz, 2013-08-24 02:05:56]

*** Submitted as https://code.google.com/p/go/source/detail?r=bc785da349e2 ***

os/user: Current support on Plan 9

Current for Plan 9 is implemented with /dev/user for
Uid/Gid/Username/Name, and $home environment variable for
HomeDir.

Implementing Lookup/LookupId is not done, which would
require parsing /adm/users. It is unclear of how much benefit
this would be.

R=golang-dev
CC=bradfitz, golang-dev, r
https://codereview.appspot.com/13203043

Committer: Brad Fitzpatrick <bradfitz@golang.org>