Issue 131900043: code review 131900043: runtime: fix windows/amd64 build after pc-relative 6l change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 131900043: code review 131900043: runtime: fix windows/amd64 build after pc-relative 6l change (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rsc

Modified:
10 years, 7 months ago

Reviewers:
brainman, minux

CC:
iant, golang-codereviews

Visibility:
Public.

Description

runtime: fix windows/amd64 build after pc-relative 6l change

Patch Set 1 #

Patch Set 2 : diff -r d9b3cbdfc09f54349ade880a7549764edebc081f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 15918878ae5153d086ea4f49d8e62bb1564ca254 https://code.google.com/p/go/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/runtime/sys_windows_amd64.s	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 7 months ago (2014-08-19 02:12:49 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=2aa982973978 *** runtime: fix windows/amd64 build after pc-relative 6l change TBR=iant CC=golang-codereviews ...

10 years, 7 months ago (2014-08-19 02:12:56 UTC) #2

brainman

Build is still broken. I will investigate when I have time. Alex

10 years, 7 months ago (2014-08-19 03:15:02 UTC) #4

Message was sent while issue was closed.

The fix https://codereview.appspot.com/127510043/

Expand All Messages | Collapse All Messages