Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(190)

Issue 131900043: code review 131900043: runtime: fix windows/amd64 build after pc-relative 6l change (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rsc
Modified:
10 years, 7 months ago
Reviewers:
brainman, minux
CC:
iant, golang-codereviews
Visibility:
Public.

Description

runtime: fix windows/amd64 build after pc-relative 6l change

Patch Set 1 #

Patch Set 2 : diff -r d9b3cbdfc09f54349ade880a7549764edebc081f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 15918878ae5153d086ea4f49d8e62bb1564ca254 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/runtime/sys_windows_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 7 months ago (2014-08-19 02:12:49 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=2aa982973978 *** runtime: fix windows/amd64 build after pc-relative 6l change TBR=iant CC=golang-codereviews ...
10 years, 7 months ago (2014-08-19 02:12:56 UTC) #2
minux
LGTM
10 years, 7 months ago (2014-08-19 02:14:07 UTC) #3
brainman
Build is still broken. I will investigate when I have time. Alex
10 years, 7 months ago (2014-08-19 03:15:02 UTC) #4
brainman
10 years, 7 months ago (2014-08-19 04:39:09 UTC) #5
Message was sent while issue was closed.
The fix https://codereview.appspot.com/127510043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b