Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 131880043: code review 131880043: gen: don't update json files on disk when only the etag... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by bradfitz
Modified:
9 years, 9 months ago
Reviewers:
gmlewis1
CC:
gmlewis1, golang-codereviews
Visibility:
Public.

Description

gen: don't update json files on disk when only the etag changes

Patch Set 1 #

Patch Set 2 : diff -r 11e893087017854fbb1db54a9fc1c0808568a428 https://code.google.com/p/google-api-go-client/ #

Patch Set 3 : diff -r 11e893087017854fbb1db54a9fc1c0808568a428 https://code.google.com/p/google-api-go-client/ #

Patch Set 4 : diff -r 11e893087017854fbb1db54a9fc1c0808568a428 https://code.google.com/p/google-api-go-client/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M google-api-go-generator/gen.go View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3
bradfitz
Hello gmlewis@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/google-api-go-client/
9 years, 9 months ago (2014-08-18 22:59:19 UTC) #1
gmlewis1
On 2014/08/18 22:59:19, bradfitz wrote: > Hello mailto:gmlewis@google.com (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...
9 years, 9 months ago (2014-08-18 23:04:37 UTC) #2
bradfitz
9 years, 9 months ago (2014-08-18 23:10:35 UTC) #3
*** Submitted as
https://code.google.com/p/google-api-go-client/source/detail?r=bade9aad9d0d ***

gen: don't update json files on disk when only the etag changes

LGTM=gmlewis
R=gmlewis
CC=golang-codereviews
https://codereview.appspot.com/131880043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b