code review 13176044: crypto/ssh: Allow customization of the client version.

crypto/ssh: Allow customization of the client version.

[jpsugar, 2013-08-26 19:30:32]

Hello agl@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[agl1, 2013-08-26 19:42:04]

What's the use case here?

[jpsugar, 2013-08-26 19:50:05]

On 2013/08/26 19:42:04, agl1 wrote:
> What's the use case here?

I have a server that expects a very specific client version, and I have to mimic
it. :(

[dave_cheney.net, 2013-08-27 01:40:53]

On 2013/08/26 19:50:05, jpsugar wrote:
> On 2013/08/26 19:42:04, agl1 wrote:
> > What's the use case here?
> 
> I have a server that expects a very specific client version, and I have to
mimic
> it. :(

Sounds like a reasonable use case. Please include a test case.

[jpsugar, 2013-08-27 16:46:20]

Hello agl@golang.org, golang-dev@googlegroups.com, dave@cheney.net (cc:
golang-dev@googlegroups.com),

Please take another look.

[agl1, 2013-08-27 16:57:30]

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go
File ssh/client.go (right):

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go#newcode21
ssh/client.go:21: const DefaultClientVersion string = "SSH-2.0-Go"
why export this?

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go#newcode67
ssh/client.go:67: var buf bytes.Buffer
the bytes.Buffer isn't needed, but don't worry about it. I'll fix that when
landing.

[jpsugar, 2013-08-27 17:07:56]

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go
File ssh/client.go (right):

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go#newcode21
ssh/client.go:21: const DefaultClientVersion string = "SSH-2.0-Go"
On 2013/08/27 16:57:30, agl1 wrote:
> why export this?

In case someone wants to know what client version we're using? I figured it
didn't hurt. Can revert this if you prefer.

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go#newcode67
ssh/client.go:67: var buf bytes.Buffer
On 2013/08/27 16:57:30, agl1 wrote:
> the bytes.Buffer isn't needed, but don't worry about it. I'll fix that when
> landing.

I was trying to preserve the single-write behavior. Were you thinking of
switching it to two c.Write() calls?

[agl1, 2013-08-27 17:40:19]

*** Submitted as
https://code.google.com/p/go/source/detail?r=e402c6ee12fd&repo=crypto ***

crypto/ssh: Allow customization of the client version.

R=agl, golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/13176044

Committer: Adam Langley <agl@golang.org>

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go
File ssh/client.go (right):

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go#newcode21
ssh/client.go:21: const DefaultClientVersion string = "SSH-2.0-Go"
On 2013/08/27 17:07:56, jpsugar wrote:
> On 2013/08/27 16:57:30, agl1 wrote:
> > why export this?
> 
> In case someone wants to know what client version we're using? I figured it
> didn't hurt. Can revert this if you prefer.

I've changed it back to private.

https://codereview.appspot.com/13176044/diff/12002/ssh/client.go#newcode67
ssh/client.go:67: var buf bytes.Buffer
On 2013/08/27 17:07:56, jpsugar wrote:
> On 2013/08/27 16:57:30, agl1 wrote:
> > the bytes.Buffer isn't needed, but don't worry about it. I'll fix that when
> > landing.
> 
> I was trying to preserve the single-write behavior. Were you thinking of
> switching it to two c.Write() calls?

No, just using a []byte rather than a whole bytes.Buffer. Done.