Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5637)

Issue 131710044: All tags as a constraint item.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by bac
Modified:
9 years, 8 months ago
Reviewers:
Marco Ceppi, mp+232758
Visibility:
Public.

Description

All tags as a constraint item. Tags are defined to be a comma-separated list of values, so an example use would be: constraints: k1=v1 k2=v2 tags=a,b,c Historically we have supported parsing constraints that used comma-separated key,value pairs, e.g. constraints: k1=v1,k2=v2,k3=v3 With the introduction of the comma-separated tags field, predictable parsing of such a string becomes difficult. This branch uses the following rules: 1) If 'tags' is included in the string then it must be of the first form. 2) If 'tags' are not present, comma-separted k,v pairs are acceptable but marked as deprecated. https://code.launchpad.net/~bac/charmworldlib/tag-constraints/+merge/232758 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworldlib/utils.py View 3 chunks +12 lines, -13 lines 0 comments Download
M tests/test_utils.py View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2
bac
Please take a look.
9 years, 8 months ago (2014-08-29 19:28:55 UTC) #1
Marco Ceppi
9 years, 8 months ago (2014-09-03 14:53:49 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b