Issue 131690043: Add ability to display/hide auto generated messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 131690043: Add ability to display/hide auto generated messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by rmistry

Modified:
9 years, 8 months ago

Reviewers:
jrobbins (corp), jrobbins (chromium)

Visibility:
Public.

More Reviews

Description

Add ability to display/hide auto generated messages. * Created a new counter for generated messages. The text will now look like: "Total messages: 3 (2 generated)". * Added new 'Show Generated Messages' and 'Hide Generated Messages' links. * Renamed 'Expand All Messages' to 'Expand Messages' and 'Collapse All Messages' to 'Collapse Messages'. * Displayed generated messages with light grey background and default border. * Generated messages are hidden by default. If the only messages that exist are generated messages then they are not hidden by default. Staged here: * <a href='https://skia-codereview-staging2.appspot.com/2510001/#msg4'>https://skia-codereview-staging2.appspot.com/2510001/#msg4</a> (extreme example that displays all message colors that currently exist in Rietveld) * <a href='https://skia-codereview-staging2.appspot.com/520001/'>https://skia-codereview-staging2.appspot.com/520001/</a> (example that does not hide generated messages by default because there are no human created messages)

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup and change purple to grey #

Total comments: 2

Patch Set 3 : Add auto_generated to API #

Patch Set 4 : Making sure nothing changed locally #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -15 lines)			Patch
M	codereview/views.py	View	1 2	3 chunks	+5 lines, -0 lines	0 comments	Download
M	static/script.js	View		2 chunks	+28 lines, -4 lines	0 comments	Download
M	static/styles.css	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	templates/issue.html	View		2 chunks	+32 lines, -11 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

esprehn

https://codereview.appspot.com/131690043/diff/20001/codereview/views.py File codereview/views.py (right): https://codereview.appspot.com/131690043/diff/20001/codereview/views.py#newcode1529 codereview/views.py:1529: if msg.auto_generated: Please expose auto_generated as a property on ...

9 years, 8 months ago (2014-08-29 18:29:07 UTC) #2

jrobbins (corp)

I agree that auto_generated should be added. I.e., to _issue_as_dict() in views.py. After that, lgtm.

9 years, 8 months ago (2014-08-29 19:46:44 UTC) #3

rmistry

9 years, 8 months ago (2014-08-29 20:23:51 UTC) #4

rmistry

9 years, 8 months ago (2014-09-02 11:36:16 UTC) #5

Message was sent while issue was closed.

Submitted as
https://code.google.com/p/rietveld/source/detail?r=12f2f6c41cfd6d6bf1769be29c...

Expand All Messages | Collapse All Messages