Issue 131660044: In debug mode, Handle and TimerHandle keeps the callback in their representation after cancel()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 131660044: In debug mode, Handle and TimerHandle keeps the callback in their representation after cancel()

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by haypo_gmail

Modified:
9 years, 7 months ago

Reviewers:
yselivanov

Visibility:
Public.

More Reviews

Description

In debug mode, Handle and TimerHandle keeps the callback in their representation after cancel()

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -17 lines)			Patch
	M	asyncio/events.py	View		4 chunks	+19 lines, -13 lines	1 comment	Download
	M	tests/test_events.py	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

yselivanov

Like the idea, the more debug info we have the better! https://codereview.appspot.com/131660044/diff/1/asyncio/events.py File asyncio/events.py (right): ...

9 years, 7 months ago (2014-09-12 22:39:45 UTC) #1

haypo_gmail

9 years, 7 months ago (2014-09-17 21:18:45 UTC) #2

On 2014/09/12 22:39:45, yselivanov wrote:
> Like the idea, the more debug info we have the better!

Cool.

> https://codereview.appspot.com/131660044/diff/1/asyncio/events.py
> File asyncio/events.py (right):
> 
> https://codereview.appspot.com/131660044/diff/1/asyncio/events.py#newcode148
> asyncio/events.py:148: pos = 2 if self._cancelled else 1
> Don't like this play with positions. Can we just always append it at the end?

I don't like this code neither, but I don't want to change the representation in
this commit. They are unit tests for repr(TimerHandle). And I like displaying
most important information at the beginning of the representation, to ease
debug.

Expand All Messages | Collapse All Messages