Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(545)

Issue 131650043: code review 131650043: database/sql: Close per-tx prepared statements when the...

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by johto
Modified:
2 years, 9 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz, mattn
Visibility:
Public.

Description

database/sql: Close per-tx prepared statements when the associated tx ends

Patch Set 1 #

Patch Set 2 : diff -r 277f98d885558a00e899f6e89958e97470fd8ab4 https://code.google.com/p/go #

Patch Set 3 : diff -r 277f98d885558a00e899f6e89958e97470fd8ab4 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 3d5b33a2459d4aeced21dde23f072cd1c5919059 https://code.google.com/p/go #

Patch Set 5 : diff -r 3d5b33a2459d4aeced21dde23f072cd1c5919059 https://code.google.com/p/go #

Total comments: 3

Patch Set 6 : diff -r 3d5b33a2459d4aeced21dde23f072cd1c5919059 https://code.google.com/p/go #

Total comments: 2

Patch Set 7 : code review 131650043: database/sql: Close per-tx prepared statements when the... #

Patch Set 8 : code review 131650043: database/sql: Close per-tx prepared statements when the... #

Patch Set 9 : diff -r 932fe22207465e6c4bcdae29f5c519ba069f8927 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -5 lines) Patch
M src/database/sql/sql.go View 1 2 3 4 5 6 7 8 7 chunks +36 lines, -5 lines 0 comments Download
M src/database/sql/sql_test.go View 1 2 3 4 5 6 7 8 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 13
johto
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
2 years, 10 months ago (2014-08-29 03:02:08 UTC) #1
johto
Hi, On 8/29/14, 5:02 AM, I wrote: > I'd like you to review this change ...
2 years, 10 months ago (2014-08-29 03:05:41 UTC) #2
bradfitz
https://codereview.appspot.com/131650043/diff/10002/src/pkg/database/sql/sql.go File src/pkg/database/sql/sql.go (right): https://codereview.appspot.com/131650043/diff/10002/src/pkg/database/sql/sql.go#newcode1189 src/pkg/database/sql/sql.go:1189: tx.stmts = append(tx.stmts, txstmt) previously it was safe to ...
2 years, 9 months ago (2014-09-02 16:22:49 UTC) #3
johto
On 2014-09-02 6:22 PM, bradfitz@golang.org wrote: > https://codereview.appspot.com/131650043/diff/10002/src/pkg/database/sql/sql.go#newcode1189 > src/pkg/database/sql/sql.go:1189: tx.stmts = append(tx.stmts, txstmt) > ...
2 years, 9 months ago (2014-09-02 19:33:23 UTC) #4
johto
Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
2 years, 9 months ago (2014-09-02 22:03:36 UTC) #5
bradfitz
https://codereview.appspot.com/131650043/diff/70001/src/pkg/database/sql/sql.go File src/pkg/database/sql/sql.go (right): https://codereview.appspot.com/131650043/diff/70001/src/pkg/database/sql/sql.go#newcode1047 src/pkg/database/sql/sql.go:1047: stmtMutex sync.Mutex // protects stmts stmtsMu sync.Mutex // guards ...
2 years, 9 months ago (2014-09-02 22:17:00 UTC) #6
johto
On 2014-09-03 00:16, bradfitz@golang.org wrote: > alternatively, you can do: > > stmts struct { ...
2 years, 9 months ago (2014-09-02 23:16:17 UTC) #7
mattn
Is this related to https://code.google.com/p/go/issues/detail?id=6734 ?
2 years, 9 months ago (2014-09-03 06:29:13 UTC) #8
johto
On 2014-09-03 08:29, mattn.jp@gmail.com wrote: > Is this related to https://code.google.com/p/go/issues/detail?id=6734 ? No, this doesn't ...
2 years, 9 months ago (2014-09-03 07:32:21 UTC) #9
bradfitz
https://codereview.appspot.com/131650043/diff/90001/src/pkg/database/sql/sql.go File src/pkg/database/sql/sql.go (right): https://codereview.appspot.com/131650043/diff/90001/src/pkg/database/sql/sql.go#newcode1029 src/pkg/database/sql/sql.go:1029: type stmts struct { don't make this a top-level ...
2 years, 9 months ago (2014-09-16 19:32:29 UTC) #10
johto
Hi Brad, On 9/16/14, 9:32 PM, bradfitz@golang.org wrote: > https://codereview.appspot.com/131650043/diff/90001/src/pkg/database/sql/sql.go#newcode1029 > src/pkg/database/sql/sql.go:1029: type stmts struct ...
2 years, 9 months ago (2014-09-21 23:54:34 UTC) #11
bradfitz
LGTM On Sun, Sep 21, 2014 at 7:54 PM, Marko Tiikkaja <marko@joh.to> wrote: > Hi ...
2 years, 9 months ago (2014-09-22 13:18:55 UTC) #12
bradfitz
2 years, 9 months ago (2014-09-22 13:19:23 UTC) #13
*** Submitted as https://code.google.com/p/go/source/detail?r=50ce4ec65c4a ***

database/sql: Close per-tx prepared statements when the associated tx ends

LGTM=bradfitz
R=golang-codereviews, bradfitz, mattn.jp
CC=golang-codereviews
https://codereview.appspot.com/131650043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted