GUI server: base deployer helpers.

GUI server: base deployer helpers.

This branch includes some helper functions
and objects that are required to implement
the Deployer and DeployMiddleware classes.

To avoid this branch to include too many 
changes, the base classes above will be 
implemented in a separate branch.

Tests: `make unittest` from the branch root.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-bundles-base-helpers/+merge/181269

(do not edit description out of merge proposal)

[frankban, 2013-08-21 11:43:06]

Please take a look.

[benji, 2013-08-21 13:18:10]

Everything LGTM.

https://codereview.appspot.com/13153043/diff/1/server/guiserver/bundles/utils.py
File server/guiserver/bundles/utils.py (right):

https://codereview.appspot.com/13153043/diff/1/server/guiserver/bundles/utils...
server/guiserver/bundles/utils.py:88: """Add a change to the deployment watcher
notifying a new position."""
I think I see that "position" is the position of the deployment in the queue but
I don't quite see how bool(position) == False implies that the deployment has
been started.  Maybe some more text in a comment the docstring would help.

[bac, 2013-08-21 14:19:17]

LGTM, thanks.

https://codereview.appspot.com/13153043/diff/1/server/guiserver/bundles/utils.py
File server/guiserver/bundles/utils.py (right):

https://codereview.appspot.com/13153043/diff/1/server/guiserver/bundles/utils...
server/guiserver/bundles/utils.py:41: - Time: the time in seconds since the
epoch as an int.
Would be nice to document the optional fields.

https://codereview.appspot.com/13153043/diff/1/server/guiserver/tests/bundles...
File server/guiserver/tests/bundles/test_utils.py (right):

https://codereview.appspot.com/13153043/diff/1/server/guiserver/tests/bundles...
server/guiserver/tests/bundles/test_utils.py:143: def
test_notify_position(self):
A test exercising showing the STARTED state would be nice.

[frankban, 2013-08-21 16:22:35]

*** Submitted:

GUI server: base deployer helpers.

This branch includes some helper functions
and objects that are required to implement
the Deployer and DeployMiddleware classes.

To avoid this branch to include too many 
changes, the base classes above will be 
implemented in a separate branch.

Tests: `make unittest` from the branch root.

R=benji, bac
CC=
https://codereview.appspot.com/13153043

https://codereview.appspot.com/13153043/diff/1/server/guiserver/bundles/utils.py
File server/guiserver/bundles/utils.py (right):

https://codereview.appspot.com/13153043/diff/1/server/guiserver/bundles/utils...
server/guiserver/bundles/utils.py:41: - Time: the time in seconds since the
epoch as an int.
On 2013/08/21 14:19:18, bac wrote:
> Would be nice to document the optional fields.

Done.

https://codereview.appspot.com/13153043/diff/1/server/guiserver/bundles/utils...
server/guiserver/bundles/utils.py:88: """Add a change to the deployment watcher
notifying a new position."""
On 2013/08/21 13:18:10, benji wrote:
> I think I see that "position" is the position of the deployment in the queue
but
> I don't quite see how bool(position) == False implies that the deployment has
> been started.  Maybe some more text in a comment the docstring would help.

Done.

https://codereview.appspot.com/13153043/diff/1/server/guiserver/tests/bundles...
File server/guiserver/tests/bundles/test_utils.py (right):

https://codereview.appspot.com/13153043/diff/1/server/guiserver/tests/bundles...
server/guiserver/tests/bundles/test_utils.py:143: def
test_notify_position(self):
On 2013/08/21 14:19:18, bac wrote:
> A test exercising showing the STARTED state would be nice.

You are right! Missed it, thank you.

[frankban, 2013-08-21 16:25:35]

Thanks for the reviews!