Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1890)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 131490043: code review 131490043: coordinator: new binary to run on GCE and manage Docker... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by bradfitz
Modified:
10 years, 7 months ago
Reviewers:
adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

coordinator: new binary to run on GCE and manage Docker builds See http://golang.org/s/builderplan (WIP doc)

Patch Set 1 #

Patch Set 2 : diff -r 918b8a7e7b1e97a664074c42688ee666b4fd906d https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 918b8a7e7b1e97a664074c42688ee666b4fd906d https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 918b8a7e7b1e97a664074c42688ee666b4fd906d https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 918b8a7e7b1e97a664074c42688ee666b4fd906d https://code.google.com/p/go.tools #

Total comments: 4

Patch Set 6 : diff -r f9e37a924785a11d4541a3cb5643465e6beee947 https://code.google.com/p/go.tools #

Patch Set 7 : diff -r f9e37a924785a11d4541a3cb5643465e6beee947 https://code.google.com/p/go.tools #

Total comments: 5

Patch Set 8 : diff -r 113b7a4d298083b54b4c9160121d8345b0606499 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -3 lines) Patch
M .hgignore View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M dashboard/README View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
A dashboard/coordinator/buildongce/create.go View 1 2 3 4 5 6 1 chunk +213 lines, -0 lines 0 comments Download
A dashboard/coordinator/main.go View 1 2 3 4 5 6 7 1 chunk +421 lines, -0 lines 0 comments Download
M dashboard/env/linux-x86-base/Dockerfile View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M dashboard/env/linux-x86-nacl/Dockerfile View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
bradfitz
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 7 months ago (2014-08-27 23:50:32 UTC) #1
bradfitz
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 7 months ago (2014-08-28 21:19:44 UTC) #2
bradfitz
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 7 months ago (2014-08-28 21:57:49 UTC) #3
adg
LGTM https://codereview.appspot.com/131490043/diff/80001/dashboard/coordinator/buildongce/create.go File dashboard/coordinator/buildongce/create.go (right): https://codereview.appspot.com/131490043/diff/80001/dashboard/coordinator/buildongce/create.go#newcode1 dashboard/coordinator/buildongce/create.go:1: package main copyright https://codereview.appspot.com/131490043/diff/80001/dashboard/coordinator/buildongce/create.go#newcode70 dashboard/coordinator/buildongce/create.go:70: os.Stdout.Write([]byte("\nEnter auth code: ...
10 years, 7 months ago (2014-08-28 22:18:57 UTC) #4
bradfitz
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 7 months ago (2014-09-03 01:07:40 UTC) #5
adg
LGTM https://codereview.appspot.com/131490043/diff/120001/dashboard/coordinator/main.go File dashboard/coordinator/main.go (right): https://codereview.appspot.com/131490043/diff/120001/dashboard/coordinator/main.go#newcode105 dashboard/coordinator/main.go:105: statusMu.Lock() put this in a func? https://codereview.appspot.com/131490043/diff/120001/dashboard/coordinator/main.go#newcode118 dashboard/coordinator/main.go:118: ...
10 years, 7 months ago (2014-09-03 03:21:32 UTC) #6
bradfitz
10 years, 7 months ago (2014-09-03 17:26:56 UTC) #7 
*** Submitted as
https://code.google.com/p/go/source/detail?r=b8731c8d080e&repo=tools ***

coordinator: new binary to run on GCE and manage Docker builds

See http://golang.org/s/builderplan (WIP doc)

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/131490043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b