code review 13139044: cmd/api: ignore GOARCH when building cmd/api.

cmd/api: ignore GOARCH when building cmd/api.

This was breaking people setting GOARCH=386 before running
all.bash on amd64 machines.

cmd/go puts different architecture binaries where "go tool"
can't find them.

[bradfitz, 2013-08-20 23:18:00]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2013-08-20 23:41:58]

shouldn't we fix go tool instead?

[bradfitz, 2013-08-20 23:43:51]

Or additionally.

But I want to get this in because Keith and Carl keep hitting this.

I can add a comment to remove this hack when/if Issue 6201 is fixed.



On Tue, Aug 20, 2013 at 4:41 PM, <r@golang.org> wrote:

> shouldn't we fix go tool instead?
>
>
https://codereview.appspot.**com/13139044/<https://codereview.appspot.com/131...
>

[r, 2013-08-20 23:49:40]

LGTM

https://codereview.appspot.com/13139044/diff/6002/src/cmd/api/run.go
File src/cmd/api/run.go (right):

https://codereview.appspot.com/13139044/diff/6002/src/cmd/api/run.go#newcode66
src/cmd/api/run.go:66: // variables from remove.
// TODO: delete when issue 6201 is fixed.

[r, 2013-08-20 23:50:32]

I'd rather just see 6201 fixed; I doubt it's hard. But OK.

On Wed, Aug 21, 2013 at 9:43 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Or additionally.
>
> But I want to get this in because Keith and Carl keep hitting this.
>
> I can add a comment to remove this hack when/if Issue 6201 is fixed.
>
>
>
> On Tue, Aug 20, 2013 at 4:41 PM, <r@golang.org> wrote:
>>
>> shouldn't we fix go tool instead?
>>
>> https://codereview.appspot.com/13139044/
>
>

[khr, 2013-08-21 03:14:34]

LGTM

https://codereview.appspot.com/13139044/diff/6002/src/cmd/api/run.go
File src/cmd/api/run.go (right):

https://codereview.appspot.com/13139044/diff/6002/src/cmd/api/run.go#newcode71
src/cmd/api/run.go:71: if strings.HasPrefix(s, r) && strings.HasPrefix(s, r+"=")
{
Why both conditionals - doesn't the second subsume the first?

[bradfitz, 2013-08-24 14:51:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=d85aa04112a1 ***

cmd/api: ignore GOARCH when building cmd/api.

This was breaking people setting GOARCH=386 before running
all.bash on amd64 machines.

cmd/go puts different architecture binaries where "go tool"
can't find them.

R=golang-dev, r, khr
CC=golang-dev
https://codereview.appspot.com/13139044