Issue 131360043: code review 131360043: goauth2: add GitHub to the list of badly behaved OAuth2...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 131360043: code review 131360043: goauth2: add GitHub to the list of badly behaved OAuth2... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by adg

Modified:
10 years, 7 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

goauth2: add more sites to the list of badly behaved OAuth2 providers Fixes issue 39. Fixes issue 40. Update issue 31

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	oauth/oauth.go	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/goauth2

10 years, 7 months ago (2014-08-27 08:51:03 UTC) #1

bradfitz

10 years, 7 months ago (2014-08-27 15:36:44 UTC) #3

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=9fc9b28b7ffa
***

goauth2: add GitHub to the list of badly behaved OAuth2 providers

Update issue 31

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/131360043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages