Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9365)

Issue 13122044: Changes how mensural flags are drawn (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by PhilEHolmes
Modified:
10 years, 8 months ago
Reviewers:
janek, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3105 complains that mensural flags do not attach to stems very well. This patch makes them attach in the same way as modern flags, and changes how they're drawn - I think the way this is now done is more metafont-y. It also gets them looking closer to all the 16C flags I can find.

Patch Set 1 #

Patch Set 2 : Formats tabs as per Werner's request #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -44 lines) Patch
M mf/parmesan-flags.mf View 1 2 chunks +28 lines, -44 lines 0 comments Download

Messages

Total messages: 9
PhilEHolmes
Please review.
10 years, 8 months ago (2013-08-20 13:15:33 UTC) #1
janek
code LGTM, and i like the new shapes.
10 years, 8 months ago (2013-08-20 15:24:16 UTC) #2
lemzwerg
LGTM, except indentation: In MF files, we use real tabs.
10 years, 8 months ago (2013-08-20 16:40:59 UTC) #3
mail_philholmes.net
----- Original Message ----- From: <lemzwerg@googlemail.com> To: <PhilEHolmes@googlemail.com>; <janek.lilypond@gmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Tuesday, August ...
10 years, 8 months ago (2013-08-20 17:03:12 UTC) #4
lemzwerg
Well, in other MF source files the `fill' operator's arguments are aligned vertically also: fill ...
10 years, 8 months ago (2013-08-20 17:10:33 UTC) #5
mail_philholmes.net
----- Original Message ----- From: <lemzwerg@googlemail.com> To: <PhilEHolmes@googlemail.com>; <janek.lilypond@gmail.com>; <mail@philholmes.net> Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: Tuesday, ...
10 years, 8 months ago (2013-08-20 17:19:51 UTC) #6
PhilEHolmes
Formats tabs as per Werner's request
10 years, 8 months ago (2013-08-22 14:07:32 UTC) #7
PhilEHolmes
Please review.
10 years, 8 months ago (2013-08-22 14:09:07 UTC) #8
lemzwerg
10 years, 8 months ago (2013-08-23 05:20:14 UTC) #9
LGTM, thanks.  In case you have time, you might replace

  { foo } z1 { bar }

with

  {foo}z1{bar}

for consistency with other files, but this is not really important.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b