Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(117)

Issue 131190043: code review 131190043: runtime: fix plan9 HeapSys accounting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dvyukov
Modified:
10 years, 8 months ago
Reviewers:
gobot, 0intro
CC:
0intro, golang-codereviews
Visibility:
Public.

Description

runtime: fix plan9 HeapSys accounting

Patch Set 1 #

Patch Set 2 : diff -r c29860623fb3ba526147d39e85617c7750913aa3 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 3

Patch Set 3 : diff -r 03b003455359b09fff0f1662255dc5fe10b93290 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 03b003455359b09fff0f1662255dc5fe10b93290 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M src/pkg/runtime/mem_plan9.c View 1 2 4 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 7
0intro
https://codereview.appspot.com/131190043/diff/20001/src/pkg/runtime/mem_plan9.c File src/pkg/runtime/mem_plan9.c (right): https://codereview.appspot.com/131190043/diff/20001/src/pkg/runtime/mem_plan9.c#newcode20 src/pkg/runtime/mem_plan9.c:20: static void( static void*
10 years, 8 months ago (2014-08-25 13:00:48 UTC) #1
0intro
LGTM with fixes. https://codereview.appspot.com/131190043/diff/20001/src/pkg/runtime/mem_plan9.c File src/pkg/runtime/mem_plan9.c (right): https://codereview.appspot.com/131190043/diff/20001/src/pkg/runtime/mem_plan9.c#newcode78 src/pkg/runtime/mem_plan9.c:78: USED(v, reserved, stat); USED(v, reserved); https://codereview.appspot.com/131190043/diff/20001/src/pkg/runtime/mem_plan9.c#newcode79 ...
10 years, 8 months ago (2014-08-25 13:28:35 UTC) #2
dvyukov
Hello 0intro@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 8 months ago (2014-08-25 13:32:14 UTC) #3
dvyukov
Please take another look and LGTM again after I mailed it.
10 years, 8 months ago (2014-08-25 13:32:59 UTC) #4
0intro
LGTM Thanks!
10 years, 8 months ago (2014-08-25 13:56:57 UTC) #5
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=a25aa660e247 *** runtime: fix plan9 HeapSys accounting LGTM=0intro R=0intro CC=golang-codereviews https://codereview.appspot.com/131190043
10 years, 8 months ago (2014-08-25 14:02:34 UTC) #6
gobot
10 years, 8 months ago (2014-08-25 14:15:48 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/2a485cfebe206c733dd731cbb6d6ad756169c7d9
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b