Issue 131150043: code review 131150043: runtime: fix arm build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 131150043: code review 131150043: runtime: fix arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rsc

Modified:
10 years, 8 months ago

Reviewers:
minux, dave

CC:
dvyukov, golang-codereviews

Visibility:
Public.

Description

runtime: fix arm build

Patch Set 1 #

Patch Set 2 : diff -r bebfeba1e59da4d4570048e941743ae2452690d9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r bebfeba1e59da4d4570048e941743ae2452690d9 https://code.google.com/p/go/ #

Patch Set 4 : diff -r bebfeba1e59da4d4570048e941743ae2452690d9 https://code.google.com/p/go/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/runtime/asm_arm.s	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello dvyukov (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 8 months ago (2014-08-24 18:04:01 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=213bbe0c1f77 *** runtime: fix arm build TBR=dvyukov CC=golang-codereviews https://codereview.appspot.com/131150043

10 years, 8 months ago (2014-08-24 18:04:08 UTC) #2

dave_cheney.net

10 years, 8 months ago (2014-08-24 19:50:17 UTC) #4

LGTM. Thanks Russ.
On 25 Aug 2014 04:15, "minux" <minux@golang.org> wrote:

> LGTM.
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

Expand All Messages | Collapse All Messages