Issue 13113045: apiserver/uniter: Resolved and GetService added

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13113045: apiserver/uniter: Resolved and GetService added (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dimitern

Modified:
10 years, 8 months ago

Reviewers:
mp+180993, rog

Visibility:
Public.

Description

apiserver/uniter: Resolved and GetService added Added two missing server-side calls to the uniter API: * Resolved * GetService Fixed some client-side uniter API TODOs to refer to these new methods. https://code.launchpad.net/~dimitern/juju-core/108-api-uniter-unit-ops/+merge/180993 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : apiserver/uniter: Resolved and GetService added #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -15 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/params/constants.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	state/api/params/internal.go	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	state/api/uniter/unit.go	View	1	5 chunks	+15 lines, -15 lines	0 comments	Download
M	state/apiserver/uniter/uniter.go	View		1 chunk	+47 lines, -0 lines	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View		1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

LGTM modulo the below. https://codereview.appspot.com/13113045/diff/1/state/api/uniter/unit.go File state/api/uniter/unit.go (right): https://codereview.appspot.com/13113045/diff/1/state/api/uniter/unit.go#newcode92 state/api/uniter/unit.go:92: func (u *Unit) Service() (*Service, ...

10 years, 8 months ago (2013-08-20 09:42:19 UTC) #2

dimitern

10 years, 8 months ago (2013-08-20 09:59:17 UTC) #3

Please take a look.

https://codereview.appspot.com/13113045/diff/1/state/api/uniter/unit.go
File state/api/uniter/unit.go (right):

https://codereview.appspot.com/13113045/diff/1/state/api/uniter/unit.go#newco...
state/api/uniter/unit.go:92: func (u *Unit) Service() (*Service, error) {
On 2013/08/20 09:42:19, rog wrote:
> As fwereade suggested, if this is just making an API call to get the service
> name, it can just do that from the unit name.

Ok, but this comment concerns .ServiceName(), not .Service(), right? Made
changes there.

Expand All Messages | Collapse All Messages