Issue 13111043: code review 13111043: net/http: do not send leading dot in cookie domain attribute

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13111043: code review 13111043: net/http: do not send leading dot in cookie domain attribute (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by volker.dobler

Modified:
11 years, 8 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

net/http: do not send leading dot in cookie domain attribute RFC 6265 allows a leading dot in a cookie domain attribute but is clear (see section 4.1.1) that a Set-Cookie header should be sent without these dots.

Patch Set 1 #

Patch Set 2 : diff -r 04f8101b46dd https://code.google.com/p/go/ #

Patch Set 3 : diff -r 04f8101b46dd https://code.google.com/p/go/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/pkg/net/http/cookie.go	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
	M	src/pkg/net/http/cookie_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

volker.dobler

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 9 months ago (2013-08-19 21:47:04 UTC) #1

bradfitz

LGTM On Mon, Aug 26, 2013 at 3:53 AM, <dr.volker.dobler@gmail.com> wrote: > gentle ping... > ...

11 years, 8 months ago (2013-08-26 12:41:09 UTC) #3

bradfitz

11 years, 8 months ago (2013-08-26 12:41:42 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=0a355d4d5c50 ***

net/http: do not send leading dot in cookie domain attribute

RFC 6265 allows a leading dot in a cookie domain attribute
but is clear (see section 4.1.1) that a Set-Cookie header
should be sent without these dots.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/13111043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages