GUI server: deployer blocking functions.

GUI server: deployer blocking functions.

This branch includes the functions and objects
required to interact with the juju-deployer library.
These functions are synchronous/blocking, they are
stored in the blocking module (inside the bundles
package) and they will be executed in a separate
process or thread.

Also implemented an InfoHandler that will be useful
when integrating the GUI server with the charm.

Tests: `make unittest` from the root of the branch.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-blocking/+merge/180855

(do not edit description out of merge proposal)

[frankban, 2013-08-19 12:20:48]

Please take a look.

[frankban, 2013-08-19 12:23:16]

Please take a look.

[teknico, 2013-08-19 13:41:03]

LGTM, great tests as usual. A few trivials.

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/bundles/bl...
File server/guiserver/bundles/blocking.py (right):

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/bundles/bl...
server/guiserver/bundles/blocking.py:58: parse the environment.yaml file in
order to retrieve the admin-secret.
environments.yaml (add an "s")

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/bundles/bl...
server/guiserver/bundles/blocking.py:105: overlapping = [i for i in env_services
if i in bundle_services]
Possibly use sets here?

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/tests/help...
File server/guiserver/tests/helpers.py (right):

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/tests/help...
server/guiserver/tests/helpers.py:181: return name, all_contents[name]
Maybe this instead of the last two lines?

    return all_contents.items()[0]

[frankban, 2013-08-19 13:57:01]

Please take a look.

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/bundles/bl...
File server/guiserver/bundles/blocking.py (right):

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/bundles/bl...
server/guiserver/bundles/blocking.py:58: parse the environment.yaml file in
order to retrieve the admin-secret.
On 2013/08/19 13:41:03, teknico wrote:
> environments.yaml (add an "s")

Done.

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/bundles/bl...
server/guiserver/bundles/blocking.py:105: overlapping = [i for i in env_services
if i in bundle_services]
On 2013/08/19 13:41:03, teknico wrote:
> Possibly use sets here?

Done.

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/tests/help...
File server/guiserver/tests/helpers.py (right):

https://codereview.appspot.com/13106043/diff/4001/server/guiserver/tests/help...
server/guiserver/tests/helpers.py:181: return name, all_contents[name]
On 2013/08/19 13:41:03, teknico wrote:
> Maybe this instead of the last two lines?
> 
>     return all_contents.items()[0]

Good catch, thanks, fixed.

[bac, 2013-08-19 19:23:48]

LGTM, thanks.

https://codereview.appspot.com/13106043/diff/10001/server/guiserver/tests/bun...
File server/guiserver/tests/bundles/test_blocking.py (right):

https://codereview.appspot.com/13106043/diff/10001/server/guiserver/tests/bun...
server/guiserver/tests/bundles/test_blocking.py:62: # Deploy a service: the
latest two arguments (force_machine and repo)
s/latest/last

[frankban, 2013-08-20 07:46:25]

*** Submitted:

GUI server: deployer blocking functions.

This branch includes the functions and objects
required to interact with the juju-deployer library.
These functions are synchronous/blocking, they are
stored in the blocking module (inside the bundles
package) and they will be executed in a separate
process or thread.

Also implemented an InfoHandler that will be useful
when integrating the GUI server with the charm.

Tests: `make unittest` from the root of the branch.

R=
CC=
https://codereview.appspot.com/13106043

https://codereview.appspot.com/13106043/diff/10001/server/guiserver/tests/bun...
File server/guiserver/tests/bundles/test_blocking.py (right):

https://codereview.appspot.com/13106043/diff/10001/server/guiserver/tests/bun...
server/guiserver/tests/bundles/test_blocking.py:62: # Deploy a service: the
latest two arguments (force_machine and repo)
On 2013/08/19 19:23:49, bac wrote:
> s/latest/last

Done.

[frankban, 2013-08-20 08:04:07]

Thank you both for the reviews!