code review 13096045: md/gc: mark panicslice as unlikely

cmd/gc: mark panicslice as unlikely

No measurable impact on performance on amd64

[volker.dobler, 2013-08-26 12:24:51]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[khr1, 2013-08-27 04:25:05]

LGTM.


On Mon, Aug 26, 2013 at 5:24 AM, <dr.volker.dobler@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> md/gc: mark panicslice as unlikely
>
> No measurable impact on performance on amd64
>
> Please review this at
https://codereview.appspot.**com/13096045/<https://codereview.appspot.com/130...
>
> Affected files:
>   M src/cmd/gc/walk.c
>
>
> Index: src/cmd/gc/walk.c
> ==============================**==============================**=======
> --- a/src/cmd/gc/walk.c
> +++ b/src/cmd/gc/walk.c
> @@ -2729,6 +2729,7 @@
>         if(chk0 != N || chk1 != N || chk2 != N) {
>                 chk = nod(OIF, N, N);
>                 chk->nbody = list1(mkcall("panicslice", T, init));
> +               chk->likely = -1;
>                 if(chk0 != N)
>                         chk->ntest = chk0;
>                 if(chk1 != N) {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[bradfitz, 2013-08-27 13:33:37]

commit message is missing the leading c in cmd



On Mon, Aug 26, 2013 at 5:24 AM, <dr.volker.dobler@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> md/gc: mark panicslice as unlikely
>
> No measurable impact on performance on amd64
>
> Please review this at
https://codereview.appspot.**com/13096045/<https://codereview.appspot.com/130...
>
> Affected files:
>   M src/cmd/gc/walk.c
>
>
> Index: src/cmd/gc/walk.c
> ==============================**==============================**=======
> --- a/src/cmd/gc/walk.c
> +++ b/src/cmd/gc/walk.c
> @@ -2729,6 +2729,7 @@
>         if(chk0 != N || chk1 != N || chk2 != N) {
>                 chk = nod(OIF, N, N);
>                 chk->nbody = list1(mkcall("panicslice", T, init));
> +               chk->likely = -1;
>                 if(chk0 != N)
>                         chk->ntest = chk0;
>                 if(chk1 != N) {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[volker.dobler, 2013-08-27 13:36:13]

PTAL

[bradfitz, 2013-08-27 13:38:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=44f80a8685c7 ***

cmd/gc: mark panicslice as unlikely

No measurable impact on performance on amd64

R=golang-dev, khr, bradfitz
CC=golang-dev
https://codereview.appspot.com/13096045

Committer: Brad Fitzpatrick <bradfitz@golang.org>