code review 13095043: cmd/dist: more informative error for mkdtemp failing

cmd/dist: more informative error for mkdtemp failing
The Darwin builders are all failing here but strerror doesn't provide context.

[r, 2013-08-18 22:18:00]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-18 22:24:41]

LGTM
 On Aug 18, 2013 3:18 PM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/dist: more informative error for mkdtemp failing
> The Darwin builders are all failing here but strerror doesn't provide
> context.
>
> Please review this at
https://codereview.appspot.**com/13095043/<https://codereview.appspot.com/130...
>
> Affected files:
>   M src/cmd/dist/unix.c
>
>
> Index: src/cmd/dist/unix.c
> ==============================**==============================**=======
> --- a/src/cmd/dist/unix.c
> +++ b/src/cmd/dist/unix.c
> @@ -467,8 +467,9 @@
>         if(b.len == 0)
>                 bwritestr(&b, "/var/tmp");
>         bwritestr(&b, "/go-cbuild-XXXXXX");
> -       if(mkdtemp(bstr(&b)) == nil)
> -               fatal("mkdtemp: %s", strerror(errno));
> +       p = bstr(&b);
> +       if(mkdtemp(p) == nil)
> +               fatal("mkdtemp(%s): %s", p, strerror(errno));
>         p = btake(&b);
>
>         bfree(&b);
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[adg, 2013-08-18 22:26:37]

I just restarted the darwin builders so this error may not arise straight
away. (although it should on cheney's machines)

[r, 2013-08-18 22:29:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=fd947a6bbee7 ***

cmd/dist: more informative error for mkdtemp failing
The Darwin builders are all failing here but strerror doesn't provide context.

R=golang-dev, bradfitz, adg
CC=golang-dev
https://codereview.appspot.com/13095043

[dave_cheney.net, 2013-08-18 23:02:31]

LGTM. 

On 19/08/2013, at 8:18, r@golang.org wrote:

> Reviewers: golang-dev1,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go/
> 
> 
> Description:
> cmd/dist: more informative error for mkdtemp failing
> The Darwin builders are all failing here but strerror doesn't provide
> context.
> 
> Please review this at https://codereview.appspot.com/13095043/
> 
> Affected files:
>  M src/cmd/dist/unix.c
> 
> 
> Index: src/cmd/dist/unix.c
> ===================================================================
> --- a/src/cmd/dist/unix.c
> +++ b/src/cmd/dist/unix.c
> @@ -467,8 +467,9 @@
>    if(b.len == 0)
>        bwritestr(&b, "/var/tmp");
>    bwritestr(&b, "/go-cbuild-XXXXXX");
> -    if(mkdtemp(bstr(&b)) == nil)
> -        fatal("mkdtemp: %s", strerror(errno));
> +    p = bstr(&b);
> +    if(mkdtemp(p) == nil)
> +        fatal("mkdtemp(%s): %s", p, strerror(errno));
>    p = btake(&b);
> 
>    bfree(&b);
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[dave_cheney.net, 2013-08-18 23:03:31]

Thanks for adding this debugging, oddly I cannot reproduce the build breakage
outside the environment created by the builder process. 

On 19/08/2013, at 8:26, Andrew Gerrand <adg@golang.org> wrote:

> I just restarted the darwin builders so this error may not arise straight
away. (although it should on cheney's machines)
> -- 
>  
> --- 
> You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.