Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 13094044: Fixes ghost name input bug in IE10

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jeff.pihach
Modified:
10 years, 8 months ago
Reviewers:
mp+180939, j.c.sackett, benji
Visibility:
Public.

Description

Fixes ghost name input bug in IE10 The height of the service name input box in the ghost inspector was causing the name to be cut off in IE10. https://code.launchpad.net/~hatch/juju-gui/fix-ie-ghost-name/+merge/180939 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes ghost name input bug in IE10 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/views/juju-inspector.less View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
10 years, 8 months ago (2013-08-19 20:24:02 UTC) #1
j.c.sackett
LGTM, QA-OK.
10 years, 8 months ago (2013-08-19 20:57:16 UTC) #2
benji
LGTM, no QA
10 years, 8 months ago (2013-08-19 21:01:09 UTC) #3
jeff.pihach
Thanks for the reviews!!
10 years, 8 months ago (2013-08-19 21:04:49 UTC) #4
jeff.pihach
10 years, 8 months ago (2013-08-19 21:11:24 UTC) #5
*** Submitted:

Fixes ghost name input bug in IE10

The height of the service name input box in
the ghost inspector was causing the name to be cut
off in IE10.

R=j.c.sackett, benji
CC=
https://codereview.appspot.com/13094044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b