Fixes the view nav for browse/build from minimized

Fixes the view nav for browse/build from minimized

-Adds viewmode controls to minimized
-Binds viewmode events into minimized
-Adds tests

https://code.launchpad.net/~jcsackett/juju-gui/browse-will-not-open-from-minimized/+merge/181151

(do not edit description out of merge proposal)

[j.c.sackett, 2013-08-20 20:37:02]

Please take a look.

[rharding, 2013-08-20 20:44:20]

LGTM with the test fixes to use done() vs the assert that might not get hit
based on the speed of the test run.

https://codereview.appspot.com/13092044/diff/1/test/test_browser_app.js
File test/test_browser_app.js (right):

https://codereview.appspot.com/13092044/diff/1/test/test_browser_app.js#newco...
test/test_browser_app.js:87: it('can toggle back to oldviewmode via the toggle',
function() {
shouldn't these take done and then call it in the view.on('viewNavigate')? Does
this really assert anything or just pass through? This is the same on all three
tests.

[jeff.pihach, 2013-08-20 20:44:46]

LGTM however I'm a little concerned about the duplication of code - possibly
create a follow-up to normalize this stuff?

https://codereview.appspot.com/13092044/diff/1/app/subapps/browser/views/mini...
File app/subapps/browser/views/minimized.js (right):

https://codereview.appspot.com/13092044/diff/1/app/subapps/browser/views/mini...
app/subapps/browser/views/minimized.js:52: Binds the viewmode control events to
navigation.
This code appears to be duplicated in other parts of the application - can it
not be split out into a mixin and then mixed into all classes which need it?

[rharding, 2013-08-20 20:44:53]

LGTM with the test fixes to use done() vs the assert that might not get hit
based on the speed of the test run.

[j.c.sackett, 2013-08-21 12:57:03]

On 2013/08/20 20:44:46, jeff.pihach wrote:
> LGTM however I'm a little concerned about the duplication of code - possibly
> create a follow-up to normalize this stuff?
> 
>
https://codereview.appspot.com/13092044/diff/1/app/subapps/browser/views/mini...
> File app/subapps/browser/views/minimized.js (right):
> 
>
https://codereview.appspot.com/13092044/diff/1/app/subapps/browser/views/mini...
> app/subapps/browser/views/minimized.js:52: Binds the viewmode control events
to
> navigation.
> This code appears to be duplicated in other parts of the application - can it
> not be split out into a mixin and then mixed into all classes which need it?

I agree it should be deduped, but the best way to do that is actually to just
have minimized also use MainView; since MainView sets up all the search stuff,
this should probably be done when we do the card "Make search bar stay when
sidebar is minimized". I'll add a comment to that effect.

[rharding, 2013-08-21 13:03:59]

On 2013/08/21 12:57:03, j.c.sackett wrote:
> On 2013/08/20 20:44:46, jeff.pihach wrote:
> > LGTM however I'm a little concerned about the duplication of code - possibly
> > create a follow-up to normalize this stuff?
> > 
> >
>
https://codereview.appspot.com/13092044/diff/1/app/subapps/browser/views/mini...
> > File app/subapps/browser/views/minimized.js (right):
> > 
> >
>
https://codereview.appspot.com/13092044/diff/1/app/subapps/browser/views/mini...
> > app/subapps/browser/views/minimized.js:52: Binds the viewmode control events
> to
> > navigation.
> > This code appears to be duplicated in other parts of the application - can
it
> > not be split out into a mixin and then mixed into all classes which need it?
> 
> I agree it should be deduped, but the best way to do that is actually to just
> have minimized also use MainView; since MainView sets up all the search stuff,
> this should probably be done when we do the card "Make search bar stay when
> sidebar is minimized". I'll add a comment to that effect.

I was wondering if the viewmode-controls widget module could provide a view
extension that could be used to provide the setup/bind event helpers for Views
to use? I thought we had done this with another module before.

[j.c.sackett, 2013-08-21 16:32:19]

*** Submitted:

Fixes the view nav for browse/build from minimized

-Adds viewmode controls to minimized
-Binds viewmode events into minimized
-Adds tests

R=rharding
CC=
https://codereview.appspot.com/13092044