Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7633)

Issue 13088043: Let add-grace-property and remove-grace-property only work in current context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dak
Modified:
10 years, 6 months ago
Reviewers:
janek, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let add-grace-property and remove-grace-property only work in current context Previously, it meddled with the grace settings of parent contexts as well. While this means that one can't set the Staff grace settings from within a Voice, it makes the behavior far more predictable.

Patch Set 1 #

Patch Set 2 : Allow settings in parent contexts #

Patch Set 3 : Add regtest (should not affect countdown) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
A input/regression/add-grace-property.ly View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 1 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4
thomasmorley651
LGTM
10 years, 8 months ago (2013-08-17 19:44:10 UTC) #1
janek
LGTM.
10 years, 8 months ago (2013-08-21 12:11:17 UTC) #2
dak
Allow settings in parent contexts
10 years, 8 months ago (2013-08-23 20:42:59 UTC) #3
dak
10 years, 8 months ago (2013-08-24 14:36:37 UTC) #4
Add regtest (should not affect countdown)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b