Hello rsc (cc: golang-codereviews@googlegroups.com, ruiu), I'd like you to review this change to https://code.google.com/p/go
LGTM JMI is short for jump if minus, maybe?
Thanks. Waiting for rsc. > JMI is short for jump if minus, maybe? Yoda conditions much Go does not use.
https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c File src/cmd/6a/lex.c (right): https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode438 src/cmd/6a/lex.c:438: "JOS", LTYPER, AJOS, /* OF = 1 */ overflow set (OF = 1) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode440 src/cmd/6a/lex.c:440: "JOC", LTYPER, AJOC, /* OF = 0 */ overflow clear (OF = 0) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode442 src/cmd/6a/lex.c:442: "JCS", LTYPER, AJCS, /* CF = 1 */ carry set (i will stop showing the paren expression but do keep it) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode447 src/cmd/6a/lex.c:447: "JCC", LTYPER, AJCC, /* CF = 0 */ carry clear https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode452 src/cmd/6a/lex.c:452: "JEQ", LTYPER, AJEQ, /* ZF = 1 */ equal https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode455 src/cmd/6a/lex.c:455: "JNE", LTYPER, AJNE, /* ZF = 0 */ not equal https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode457 src/cmd/6a/lex.c:457: "JLS", LTYPER, AJLS, /* CF = 1 || ZF = 1 */ lower or same (unsigned) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode460 src/cmd/6a/lex.c:460: "JHI", LTYPER, AJHI, /* CF = 0 && ZF = 0 */ higher (unsigned) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode463 src/cmd/6a/lex.c:463: "JMI", LTYPER, AJMI, /* SF = 1 */ negative (minus) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode465 src/cmd/6a/lex.c:465: "JPL", LTYPER, AJPL, /* SF = 0 */ non-negative (plus) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode467 src/cmd/6a/lex.c:467: "JPS", LTYPER, AJPS, /* PF = 1 */ parity set https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode470 src/cmd/6a/lex.c:470: "JPC", LTYPER, AJPC, /* PF = 0 */ parity clear https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode473 src/cmd/6a/lex.c:473: "JLT", LTYPER, AJLT, /* SF != OF */ less than (signed) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode476 src/cmd/6a/lex.c:476: "JGE", LTYPER, AJGE, /* SF = OF */ greater than or equal (signed) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode478 src/cmd/6a/lex.c:478: "JLE", LTYPER, AJLE, /* ZF = 1 || SF != OF */ less than or equal (signed) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode480 src/cmd/6a/lex.c:480: "JGT", LTYPER, AJGT, /* ZF = 0 && SF = OF */ greater than (signed) https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode615 src/cmd/6a/lex.c:615: "SETCC", LTYPE1, ASETCC, /* CF = 0 */ don't comment these. there are comments above. if you want, put this on the first one only: /* see JCC etc above for condition codes */ https://codereview.appspot.com/130870043/diff/40001/src/cmd/6a/lex.c#newcode683 src/cmd/6a/lex.c:683: "CMOVLCC", LTYPE3, ACMOVLCC, don't comment these either. :-) https://codereview.appspot.com/130870043/diff/40001/src/cmd/8a/lex.c File src/cmd/8a/lex.c (right): https://codereview.appspot.com/130870043/diff/40001/src/cmd/8a/lex.c#newcode496 src/cmd/8a/lex.c:496: "SETCC", LTYPE1, ASETCC, /* CF = 0 */ don't comment these. there are comments above.
Thanks! All done. PTAL
LGTM
*** Submitted as https://code.google.com/p/go/source/detail?r=d5fab45818b5 *** cmd/6a, cmd/8a: document AJxx condition codes LGTM=ruiu, rsc R=rsc, ruiu CC=golang-codereviews https://codereview.appspot.com/130870043
