Issue 13084049: code review 13084049: cmd/api: be more robust against OS deleting temp files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13084049: code review 13084049: cmd/api: be more robust against OS deleting temp files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bradfitz

Modified:
11 years, 9 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/api: be more robust against OS deleting temp files OS X in particular deletes tmp files (but not directories) pretty reliably. Ask hg whether the go.tools directory in tmp is good before using it. Fixes issue Rob and others were reporting, which I just hit myself now.

Patch Set 1 #

Patch Set 2 : diff -r d85aa04112a1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d85aa04112a1 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d85aa04112a1 https://go.googlecode.com/hg/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
	M	src/cmd/api/run.go	View	1	2 chunks	+29 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 9 months ago (2013-08-24 15:07:43 UTC) #1

bradfitz

11 years, 9 months ago (2013-08-24 21:55:03 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=15128109f9ed ***

cmd/api: be more robust against OS deleting temp files

OS X in particular deletes tmp files (but not directories)
pretty reliably.

Ask hg whether the go.tools directory in tmp is good before
using it.

Fixes issue Rob and others were reporting, which I just hit
myself now.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13084049

Expand All Messages | Collapse All Messages