Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1499)

Issue 13084045: Add support for providing constraints on deploy.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rharding
Modified:
10 years, 7 months ago
Reviewers:
mp+181610, jeff.pihach, matthew.scott
Visibility:
Public.

Description

Add support for providing constraints on deploy. - The deploy methods for both environments assume constraints is an empty object. - This adds support for the constraints on both go/python environments. - For the go environment we have to map the names of the constraints from the ones provided to the user to the Go Caps names required. - Updates fakebackend and sandboxes for the changes accepting constraints as well. - This required adding another argument to env.deploy() and a bunch of adding a 'null' constraints argument to those calls. This, of course, led to lint'ing needing to kick in and resize the long lines. https://code.launchpad.net/~rharding/juju-gui/deploy-constraints/+merge/181610 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add support for providing constraints on deploy. #

Total comments: 4

Patch Set 3 : Add support for providing constraints on deploy. #

Total comments: 1

Patch Set 4 : Add support for providing constraints on deploy. #

Patch Set 5 : Add support for providing constraints on deploy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -49 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M app/store/env/go.js View 1 2 3 6 chunks +77 lines, -4 lines 0 comments Download
M app/store/env/python.js View 1 chunk +2 lines, -1 line 0 comments Download
M app/store/env/sandbox.js View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M app/views/charm.js View 1 chunk +3 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/ghost-inspector.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_charm_panel.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/test_env_go.js View 1 2 3 chunks +67 lines, -8 lines 0 comments Download
M test/test_env_python.js View 2 chunks +12 lines, -1 line 0 comments Download
M test/test_fakebackend.js View 1 chunk +24 lines, -0 lines 0 comments Download
M test/test_sandbox_go.js View 1 2 6 chunks +67 lines, -29 lines 0 comments Download
M test/test_sandbox_python.js View 1 2 6 chunks +41 lines, -3 lines 0 comments Download

Messages

Total messages: 9
rharding
Please take a look.
10 years, 7 months ago (2013-08-22 17:26:50 UTC) #1
rharding
Please take a look.
10 years, 7 months ago (2013-08-22 17:37:58 UTC) #2
jeff.pihach
LGTM Thanks for this update! https://codereview.appspot.com/13084045/diff/4001/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/13084045/diff/4001/app/store/env/go.js#newcode356 app/store/env/go.js:356: if (typeof constraints === ...
10 years, 7 months ago (2013-08-22 17:52:50 UTC) #3
matthew.scott
Quick comment below; will QA in a few. https://codereview.appspot.com/13084045/diff/4001/app/store/env/sandbox.js File app/store/env/sandbox.js (right): https://codereview.appspot.com/13084045/diff/4001/app/store/env/sandbox.js#newcode485 app/store/env/sandbox.js:485: constraints: ...
10 years, 7 months ago (2013-08-22 17:53:29 UTC) #4
matthew.scott
QA Good. LGTM with go sandbox handling constraints
10 years, 7 months ago (2013-08-22 18:14:38 UTC) #5
rharding
Please take a look.
10 years, 7 months ago (2013-08-23 14:03:37 UTC) #6
matthew.scott
LGTM, thanks for getting this in! https://codereview.appspot.com/13084045/diff/11001/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/13084045/diff/11001/app/store/env/go.js#newcode265 app/store/env/go.js:265: @return {undefined} No;thing. ...
10 years, 7 months ago (2013-08-23 14:19:21 UTC) #7
matthew.scott
LGTM, thanks for getting this in! https://codereview.appspot.com/13084045/diff/11001/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/13084045/diff/11001/app/store/env/go.js#newcode265 app/store/env/go.js:265: @return {undefined} No;thing. ...
10 years, 7 months ago (2013-08-23 14:19:21 UTC) #8
rharding
10 years, 7 months ago (2013-08-23 14:38:40 UTC) #9
*** Submitted:

Add support for providing constraints on deploy.

- The deploy methods for both environments assume constraints is an empty
object.
- This adds support for the constraints on both go/python environments.
- For the go environment we have to map the names of the constraints from the
ones provided to the user to the Go Caps names required.
- Updates fakebackend and sandboxes for the changes accepting constraints as
well.
- This required adding another argument to env.deploy() and a bunch of adding
a 'null' constraints argument to those calls. This, of course, led to lint'ing
needing to kick in and resize the long lines.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/13084045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b