Add support for providing constraints on deploy.

Add support for providing constraints on deploy.

- The deploy methods for both environments assume constraints is an empty
object.
- This adds support for the constraints on both go/python environments.
- For the go environment we have to map the names of the constraints from the
ones provided to the user to the Go Caps names required.
- Updates fakebackend and sandboxes for the changes accepting constraints as
well.
- This required adding another argument to env.deploy() and a bunch of adding
a 'null' constraints argument to those calls. This, of course, led to lint'ing
needing to kick in and resize the long lines.

https://code.launchpad.net/~rharding/juju-gui/deploy-constraints/+merge/181610

(do not edit description out of merge proposal)

[rharding, 2013-08-22 17:26:50]

Please take a look.

[rharding, 2013-08-22 17:37:58]

Please take a look.

[jeff.pihach, 2013-08-22 17:52:50]

LGTM Thanks for this update!

https://codereview.appspot.com/13084045/diff/4001/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/13084045/diff/4001/app/store/env/go.js#newcode356
app/store/env/go.js:356: if (typeof constraints === 'function') {
I'm assuming that this was put in as a safety measure? Can it be removed now and
just let it fail?

https://codereview.appspot.com/13084045/diff/4001/app/store/env/go.js#newcode367
app/store/env/go.js:367: constraints = goConstraints;
This doesn't cause any issues for pyju?

https://codereview.appspot.com/13084045/diff/4001/test/test_env_go.js
File test/test_env_go.js (right):

https://codereview.appspot.com/13084045/diff/4001/test/test_env_go.js#newcode506
test/test_env_go.js:506: 'precise/mysql', 'mysql', null, null, null, null,
function(data) {
pick-a-null, any null!

[matthew.scott, 2013-08-22 17:53:29]

Quick comment below; will QA in a few.

https://codereview.appspot.com/13084045/diff/4001/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/13084045/diff/4001/app/store/env/sandbox.js#ne...
app/store/env/sandbox.js:485: constraints: data.constraints,
This is for the python sandbox, should also be done with the go one as well? 
handleClientServiceDeploy, I think the method is called.

[matthew.scott, 2013-08-22 18:14:38]

QA Good.  LGTM with go sandbox handling constraints

[rharding, 2013-08-23 14:03:37]

Please take a look.

[matthew.scott, 2013-08-23 14:19:21]

LGTM, thanks for getting this in!

https://codereview.appspot.com/13084045/diff/11001/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/13084045/diff/11001/app/store/env/go.js#newcod...
app/store/env/go.js:265: @return {undefined} No;thing.
Trivial: revert

[matthew.scott, 2013-08-23 14:19:21]

LGTM, thanks for getting this in!

https://codereview.appspot.com/13084045/diff/11001/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/13084045/diff/11001/app/store/env/go.js#newcod...
app/store/env/go.js:265: @return {undefined} No;thing.
Trivial: revert

[rharding, 2013-08-23 14:38:40]

*** Submitted:

Add support for providing constraints on deploy.

- The deploy methods for both environments assume constraints is an empty
object.
- This adds support for the constraints on both go/python environments.
- For the go environment we have to map the names of the constraints from the
ones provided to the user to the Go Caps names required.
- Updates fakebackend and sandboxes for the changes accepting constraints as
well.
- This required adding another argument to env.deploy() and a bunch of adding
a 'null' constraints argument to those calls. This, of course, led to lint'ing
needing to kick in and resize the long lines.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/13084045