Issue 13083043: code review 13083043: cmd/gc: fix method values whose receiver is an unnamed ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13083043: code review 13083043: cmd/gc: fix method values whose receiver is an unnamed ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by remyoudompheng

Modified:
11 years, 8 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/gc: fix method values whose receiver is an unnamed interface. Fixes issue 6140.

Patch Set 1 #

Patch Set 2 : diff -r 0a5af862666a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0a5af862666a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f974949adf23 https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -4 lines)			Patch
M	src/cmd/gc/closure.c	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
A	test/fixedbugs/issue6140.go	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	test/method2.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 9 months ago (2013-08-17 09:54:20 UTC) #1

remyoudompheng

11 years, 8 months ago (2013-08-29 08:01:24 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=80771ad49cb6 ***

cmd/gc: fix method values whose receiver is an unnamed interface.

Fixes issue 6140.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/13083043

Expand All Messages | Collapse All Messages