Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(141)

Issue 130830043: code review 130830043: html/template: don't panic on second execution of unesc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by adg
Modified:
10 years, 7 months ago
Reviewers:
r
CC:
golang-codereviews, r, minux
Visibility:
Public.

Description

html/template: don't panic on second execution of unescapable template Fixes issue 8431.

Patch Set 1 #

Patch Set 2 : diff -r 15918878ae5153d086ea4f49d8e62bb1564ca254 https://code.google.com/p/go #

Patch Set 3 : diff -r 8f918b7db01b9ca6aec57bd67d58da9f1d734e2a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M src/pkg/html/template/escape.go View 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/html/template/escape_test.go View 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/html/template/template.go View 1 13 chunks +22 lines, -14 lines 0 comments Download

Messages

Total messages: 14
adg
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2014-08-18 07:36:44 UTC) #1
adg
R=r
10 years, 7 months ago (2014-08-18 07:37:04 UTC) #2
r
a little troubled this required adding an import that wasn't needed before. is there another ...
10 years, 7 months ago (2014-08-18 16:00:55 UTC) #3
adg
On 2014/08/18 16:00:55, r wrote: > a little troubled this required adding an import that ...
10 years, 7 months ago (2014-08-18 22:27:21 UTC) #4
minux
On Mon, Aug 18, 2014 at 6:27 PM, <adg@golang.org> wrote: > On 2014/08/18 16:00:55, r ...
10 years, 7 months ago (2014-08-18 22:33:16 UTC) #5
adg
I just checked; scan.go already imports "errors". Any reason to avoid doing so in print.go? ...
10 years, 7 months ago (2014-08-18 22:41:37 UTC) #6
r
my concern is not the import per se, but the implication that it's a new ...
10 years, 7 months ago (2014-08-18 22:50:04 UTC) #7
adg
On 19 August 2014 08:49, Rob Pike <r@golang.org> wrote: > my concern is not the ...
10 years, 7 months ago (2014-08-18 22:51:58 UTC) #8
adg
On 19 August 2014 08:51, Andrew Gerrand <adg@golang.org> wrote: > Another file in package fmt. ...
10 years, 7 months ago (2014-08-18 22:52:38 UTC) #9
r
no, it's what i said: a new strategy for creating errors. i should look, but: ...
10 years, 7 months ago (2014-08-18 22:57:47 UTC) #10
adg
fmt.Errorf. On 19 August 2014 08:57, Rob Pike <r@golang.org> wrote: > no, it's what i ...
10 years, 7 months ago (2014-08-18 23:00:40 UTC) #11
adg
PTAL I switched to fmt.Errorf
10 years, 7 months ago (2014-08-19 01:37:11 UTC) #12
r
LGTM
10 years, 7 months ago (2014-08-19 03:52:51 UTC) #13
adg
10 years, 7 months ago (2014-08-19 04:24:23 UTC) #14
*** Submitted as https://code.google.com/p/go/source/detail?r=8cfc3e423d17 ***

html/template: don't panic on second execution of unescapable template

Fixes issue 8431.

LGTM=r
R=golang-codereviews, r, minux
CC=golang-codereviews
https://codereview.appspot.com/130830043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b