Update jshint to 2.1.9

Update jshint to 2.1.9

This branch updates jshint to the most recent version.
Because of the new version some of the configuration
options have changed so it needed to be modified.
This branch also fixes the issues reported by the update
and converted old inline jshint flags to the new format.

https://code.launchpad.net/~hatch/juju-gui/upgrade-jshint/+merge/180649

(do not edit description out of merge proposal)

[jeff.pihach, 2013-08-16 20:20:40]

Please take a look.

[j.c.sackett, 2013-08-16 20:23:49]

LGTM, though I have one question and would appreciate if you could add comments
to JS hint codes to indicate what lint rule you're trying to ignore in each
case.

https://codereview.appspot.com/13072043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/13072043/diff/1/Makefile#newcode262
Makefile:262: node_modules/jshint/bin/jshint --verbose $(JSFILES)
Why verbose? Didn't we remove a bunch of output from linting? Why do we want to
add more?

[jeff.pihach, 2013-08-16 20:29:16]

On 2013/08/16 20:23:49, j.c.sackett wrote:
> LGTM, though I have one question and would appreciate if you could add
comments
> to JS hint codes to indicate what lint rule you're trying to ignore in each
> case.

Sure can do!

> https://codereview.appspot.com/13072043/diff/1/Makefile
> File Makefile (right):
> 
> https://codereview.appspot.com/13072043/diff/1/Makefile#newcode262
> Makefile:262: node_modules/jshint/bin/jshint --verbose $(JSFILES)
> Why verbose? Didn't we remove a bunch of output from linting? Why do we want
to
> add more?

This doesn't really make it 'verbose' it simply adds the error code to the end
of the report.

[jeff.pihach, 2013-08-19 15:18:24]

Please take a look.

[bac, 2013-08-19 15:33:36]

LGTM and it QAs fine.  I agree with Jon that comments stating what is being
ignored would be good.  (You said you could do it but haven't yet, right?)

I assume this new version only allows warning message code numbers in the ignore
syntax instead of the more explicit variable naming that it replaces?  That
change seems like a regression to me.

Thanks for taking it on and getting our use of jshint modernized.

https://codereview.appspot.com/13072043/diff/7001/.jshintrc
File .jshintrc (right):

https://codereview.appspot.com/13072043/diff/7001/.jshintrc#newcode2
.jshintrc:2: // The basis for this file was taken from
https://github.com/oryband/dotfiles/blob/master/jshintrc
Please split the line before the URL.

https://codereview.appspot.com/13072043/diff/7001/.jshintrc#newcode9
.jshintrc:9: // Predefined globals whom JSHint will ignore.
s/whom/that

https://codereview.appspot.com/13072043/diff/7001/app/modules-debug.js
File app/modules-debug.js (right):

https://codereview.appspot.com/13072043/diff/7001/app/modules-debug.js#newcode33
app/modules-debug.js:33: /* jshint -W079 */
What warning does this disable?  It may be worth commenting.

[jeff.pihach, 2013-08-19 15:55:13]

Thanks for the reviews! I have added the inline comments explaining which error
those flags ignore and updated as per the other comments.

[jeff.pihach, 2013-08-19 16:01:44]

*** Submitted:

Update jshint to 2.1.9

This branch updates jshint to the most recent version.
Because of the new version some of the configuration
options have changed so it needed to be modified.
This branch also fixes the issues reported by the update
and converted old inline jshint flags to the new format.

R=j.c.sackett, bac
CC=
https://codereview.appspot.com/13072043