Issue 13060048: code review 13060048: net/smtp: clarify that SendMail's auth param is optional

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13060048: code review 13060048: net/smtp: clarify that SendMail's auth param is optional (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bradfitz

Modified:
11 years, 8 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

net/smtp: clarify that SendMail's auth param is optional It wasn't obvious that the Auth could be nil.

Patch Set 1 #

Patch Set 2 : diff -r cddeaea05b11 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cddeaea05b11 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r cddeaea05b11 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 1e3289919b26 https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/pkg/net/smtp/smtp.go	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 9 months ago (2013-08-23 02:46:53 UTC) #1

bradfitz

11 years, 8 months ago (2013-08-27 23:12:36 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2cf2e4e035ab ***

net/smtp: clarify that SendMail's auth param is optional

It wasn't obvious that the Auth could be nil.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/13060048

Expand All Messages | Collapse All Messages