Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(137)

Issue 130590043: Moved NullMemoryNotifier (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by peterssen
Modified:
6 years, 8 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Promoted NullMemoryNotifier outside unit tests. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2271

Patch Set 1 : Added a reference to unittest_util.h #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -37 lines) Patch
M syzygy/agent/asan/asan.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + syzygy/agent/asan/memory_notifiers/null_memory_notifier.h View 1 2 chunks +11 lines, -16 lines 0 comments Download
M syzygy/agent/asan/unittest_util.h View 3 chunks +2 lines, -21 lines 0 comments Download

Messages

Total messages: 4
peterssen
PTAL. Promoted NullMemoryNotifier, it is useless outside unit tests, but allows non-finished code to work. ...
6 years, 8 months ago (2014-08-26 15:01:51 UTC) #1
Sébastien Marchand
lgtm. Please use my @chromium address when you add me to a code review. https://codereview.appspot.com/130590043/diff/40001/syzygy/agent/asan/memory_notifiers/null_memory_notifier.h ...
6 years, 8 months ago (2014-08-26 17:07:17 UTC) #2
peterssen
Fixed, committing. https://codereview.appspot.com/130590043/diff/40001/syzygy/agent/asan/memory_notifiers/null_memory_notifier.h File syzygy/agent/asan/memory_notifiers/null_memory_notifier.h (right): https://codereview.appspot.com/130590043/diff/40001/syzygy/agent/asan/memory_notifiers/null_memory_notifier.h#newcode26 syzygy/agent/asan/memory_notifiers/null_memory_notifier.h:26: // notifier. On 2014/08/26 17:07:17, sebmarchand - ...
6 years, 8 months ago (2014-08-26 17:14:03 UTC) #3
peterssen
6 years, 8 months ago (2014-08-26 17:58:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 2271 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b