Issue 130590043: Moved NullMemoryNotifier

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 130590043: Moved NullMemoryNotifier (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by peterssen

Modified:
9 years, 7 months ago

Reviewers:
Sébastien Marchand, chrisha

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Promoted NullMemoryNotifier outside unit tests. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2271

Patch Set 1 : Added a reference to unittest_util.h #

Total comments: 2

Patch Set 2 : Nit #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -37 lines)			Patch
M	syzygy/agent/asan/asan.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	syzygy/agent/asan/memory_notifiers/null_memory_notifier.h	View	1	2 chunks	+11 lines, -16 lines	0 comments	Download
M	syzygy/agent/asan/unittest_util.h	View		3 chunks	+2 lines, -21 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

peterssen

PTAL. Promoted NullMemoryNotifier, it is useless outside unit tests, but allows non-finished code to work. ...

9 years, 7 months ago (2014-08-26 15:01:51 UTC) #1

Sébastien Marchand

lgtm. Please use my @chromium address when you add me to a code review. https://codereview.appspot.com/130590043/diff/40001/syzygy/agent/asan/memory_notifiers/null_memory_notifier.h ...

9 years, 7 months ago (2014-08-26 17:07:17 UTC) #2

peterssen

Fixed, committing. https://codereview.appspot.com/130590043/diff/40001/syzygy/agent/asan/memory_notifiers/null_memory_notifier.h File syzygy/agent/asan/memory_notifiers/null_memory_notifier.h (right): https://codereview.appspot.com/130590043/diff/40001/syzygy/agent/asan/memory_notifiers/null_memory_notifier.h#newcode26 syzygy/agent/asan/memory_notifiers/null_memory_notifier.h:26: // notifier. On 2014/08/26 17:07:17, sebmarchand - ...

9 years, 7 months ago (2014-08-26 17:14:03 UTC) #3

peterssen

9 years, 7 months ago (2014-08-26 17:58:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 2271 (presubmit successful).

Expand All Messages | Collapse All Messages