Hello daniel.morsing@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 8 months ago
(2014-08-23 15:57:03 UTC)
#1
LGTM On Sat, Aug 23, 2014 at 8:57 AM, dvyukov via golang-codereviews < golang-codereviews@googlegroups.com> wrote: ...
10 years, 8 months ago
(2014-08-23 16:07:45 UTC)
#2
LGTM
On Sat, Aug 23, 2014 at 8:57 AM, dvyukov via golang-codereviews <
golang-codereviews@googlegroups.com> wrote:
> Reviewers: DMorsing,
>
> Message:
> Hello daniel.morsing@gmail.com (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> runtime: remove unused var
>
> Please review this at https://codereview.appspot.com/130500044/
>
> Affected files (+0, -1 lines):
> M src/pkg/runtime/proc.c
>
>
> Index: src/pkg/runtime/proc.c
> ===================================================================
> --- a/src/pkg/runtime/proc.c
> +++ b/src/pkg/runtime/proc.c
> @@ -1868,7 +1868,6 @@
> void *callerpc;
> FuncVal *fn;
> int32 siz;
> - G *spawng;
>
> siz = g->m->scalararg[0];
> callerpc = (void*)g->m->scalararg[1];
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Issue 130500044: code review 130500044: runtime: remove unused var
(Closed)
Created 10 years, 8 months ago by dvyukov
Modified 10 years, 8 months ago
Reviewers:
Base URL:
Comments: 0