code review 130440043: cmd/gofmt: make test files self-describing

cmd/gofmt: make test files self-describing

1) Interpret a comment of the form

//gofmt <flags>

in test files to drive the respective
gofmt command. Eliminates the need to
enumerate all test files in the test
harness.

2) Added -update flag to make it easier
to update test cases.

[gri, 2014-08-21 23:45:44]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[josharian, 2014-08-22 00:22:55]

LGTM

Oddly, clpatch fails here:

$ hg clp 130440043
edit src/cmd/gofmt/testdata/crlf.input: patch did not apply cleanly
abort: hgapplydiff failed

I wonder whether CRs confuse mercurial or hgapplydiff.

[gri, 2014-08-22 00:24:17]

Thanks.

crlf.input contains \r\n newlines (on purpose) - I suspect that might be
issue.

- gri


On Thu, Aug 21, 2014 at 5:22 PM, <josharian@gmail.com> wrote:

> LGTM
>
> Oddly, clpatch fails here:
>
> $ hg clp 130440043
> edit src/cmd/gofmt/testdata/crlf.input: patch did not apply cleanly
> abort: hgapplydiff failed
>
> I wonder whether CRs confuse mercurial or hgapplydiff.
>
>
> https://codereview.appspot.com/130440043/
>

[gri, 2014-08-22 00:25:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=8e4e7940943a ***

cmd/gofmt: make test files self-describing

1) Interpret a comment of the form

//gofmt <flags>

in test files to drive the respective
gofmt command. Eliminates the need to
enumerate all test files in the test
harness.

2) Added -update flag to make it easier
to update test cases.

LGTM=josharian
R=golang-codereviews, josharian
CC=golang-codereviews
https://codereview.appspot.com/130440043

[gobot, 2014-08-22 02:52:47]

This CL appears to have broken the linux-arm-panda builder.
See http://build.golang.org/log/7fc711eb605af036d0760a00ed129cd6809df658

[dvyukov, 2014-08-22 08:03:24]

I think this has broken nacl build:

--- FAIL: TestRewrite (0.80s)
	gofmt_test.go:90: open gofmt.go: No such file or directory
	gofmt_test.go:90: open gofmt_test.go: No such file or directory
FAIL
FAIL	cmd/gofmt	1.030s

[dave_cheney.net, 2014-08-22 08:04:44]

I'm testing a fix now.

On Fri, Aug 22, 2014 at 6:03 PM, dvyukov via golang-codereviews
<golang-codereviews@googlegroups.com> wrote:
> I think this has broken nacl build:
>
> --- FAIL: TestRewrite (0.80s)
>         gofmt_test.go:90: open gofmt.go: No such file or directory
>         gofmt_test.go:90: open gofmt_test.go: No such file or directory
> FAIL
> FAIL    cmd/gofmt       1.030s
>
>
>
> https://codereview.appspot.com/130440043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[dave_cheney.net, 2014-08-22 08:20:57]

https://codereview.appspot.com/132820044/

I am having trouble getting a reliable nacl environment to test this,
but I believe this fix is correct.

On Fri, Aug 22, 2014 at 6:04 PM, Dave Cheney <dave@cheney.net> wrote:
> I'm testing a fix now.
>
> On Fri, Aug 22, 2014 at 6:03 PM, dvyukov via golang-codereviews
> <golang-codereviews@googlegroups.com> wrote:
>> I think this has broken nacl build:
>>
>> --- FAIL: TestRewrite (0.80s)
>>         gofmt_test.go:90: open gofmt.go: No such file or directory
>>         gofmt_test.go:90: open gofmt_test.go: No such file or directory
>> FAIL
>> FAIL    cmd/gofmt       1.030s
>>
>>
>>
>> https://codereview.appspot.com/130440043/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.