Issue 13041: Revision of http://codereview.appspot.com/12874

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13041: Revision of http://codereview.appspot.com/12874

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by Aidamina

Modified:
15 years, 2 months ago

Reviewers:
brad_danga_com

Base URL:
http://google-sgnodemapper.googlecode.com/svn/trunk/trunk/

Visibility:
Public.

Description

Revision of http://codereview.appspot.com/12874 Code style review

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revised as a result of comments #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -0 lines)			Patch
		demo_new.html	View		1 chunk	+34 lines, -0 lines	0 comments	Download
		demo_new.js	View	1	1 chunk	+117 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brad_danga_com

LGTM. Feel free to check in. http://codereview.appspot.com/13041/diff/1/3 File demo_new.js (right): http://codereview.appspot.com/13041/diff/1/3#newcode75 Line 75: if(sites.length == ...

15 years, 2 months ago (2009-02-03 00:38:26 UTC) #2

Revised as a result of comments

Expand All Messages | Collapse All Messages